Added the Azure.MixedReality.Authentication library #17571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
craigktreasure
force-pushed
the
craig/mr-sts-sdk
branch
from
c2e8f9d
to
518dee8
Compare
craigktreasure
changed the title
craigktreasure
requested review from
AlexGhiondea,
KrzysztofCwalina and
pakrym
as code owners
added 8 commits
December 16, 2020 10:00
- This change adds an authentication library for Mixed Reality services, which utilize a custom STS for authentication. Upcoming Mixed Reality client libraries will depend on this library to perform authentication using identities from Azure.Identity. See documentation for more information.
- To simplify this particular library, we've decided to make the STS client an internal detail to other Mixed Reality clients. We're not going to expose a common credential and each of the clients will be responsible for exchanging the common `TokenCredential` types from Azure.Identity for a Mixed Reality access token using the `MixedRealityStsClient`.
craigktreasure
force-pushed
the
craig/mr-sts-sdk
branch
from
518dee8
to
3c0afb1
Compare
craigktreasure
commented
Dec 16, 2020
|
|
||
| using System.Diagnostics.CodeAnalysis; | ||
|
|
||
| [assembly: SuppressMessage("Usage", "AZC0001:Use one of the following pre-approved namespace groups (https://azure.github.io/azure-sdk/registered_namespaces.html): Azure.AI, Azure.Analytics, Azure.Communication, Azure.Data, Azure.DigitalTwins, Azure.Iot, Azure.Learn, Azure.Media, Azure.Management, Azure.Messaging, Azure.Search, Azure.Security, Azure.Storage, Azure.Template, Azure.Identity, Microsoft.Extensions.Azure", Justification = "<Pending>", Scope = "namespace", Target = "~N:Azure.MixedReality.Authentication")] |
There was a problem hiding this comment.
@AlexGhiondea I forgot I had these suppressions. We'll be adding more clients to the Azure.MixedReality umbrella, so is it worth adding Azure.MixedReality to the list or would you prefer a different solution?
There was a problem hiding this comment.
We did have a discussion about this in the SDK API review and determined that the Azure.MixedReality name was necessary, so I don't expect we'll need to revisit that, but the tooling will need to be updated at some point.
vriveras
approved these changes
Dec 17, 2020
|
Hello @craigktreasure! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
annelo-msft
pushed a commit
to annelo-msft/azure-sdk-for-net
that referenced
this pull request
Feb 17, 2021
This change adds an authentication library for Mixed Reality services, which all currently utilize a custom STS for authentication. Upcoming Mixed Reality client libraries will depend on this library to perform authentication using identities from Azure.Identity. See the added `README.md` for more information about the library. [ApiView link](https://apiview.dev/Assemblies/Review/35afdb6afa874f6ab4caa1cfaf7a15cd)
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds an authentication library for Mixed Reality services, which all currently utilize a custom STS for authentication. Upcoming Mixed Reality client libraries will depend on this library to perform authentication using identities from Azure.Identity. See the added
README.mdfor more information about the library.ApiView link