-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TA] Assigning canary to centraluseuap #17517
Conversation
/azp run net - textanalytics - tests-weekly |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run net - textanalytics - tests-weekly |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run net - textanalytics - tests-weekly |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run net - textanalytics |
Azure Pipelines successfully started running 1 pipeline(s). |
SubscriptionConfiguration: $(sub-config-azure-cloud-test-resources) | ||
Canary: | ||
SubscriptionConfiguration: $(sub-config-azure-cloud-test-resources) | ||
Location: 'centraluseuap' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we want it, I was thinking of adding a CanaryLocation parameter to avoid the need for this, but also wanted to avoid too much parameter bloat at the same time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry Ben. I forgot about this PR before I went on vacation.
I will prefer that, so we don't have duplication of the other clouds or configuration in each library.
Do you envision that other clouds would like to have their specific Location too? or only applies for Canary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to merge this PR as is to unblock the build.
/azp run net - textanalytics - tests-weekly |
Azure Pipelines successfully started running 1 pipeline(s). |
* assigning canary to centraluseuap * override the whole thing
Fixes: #17483 (TA part)
Following guidance here: https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/389/-.net-Configuring-Live-Tests?anchor=supported-clouds