Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TA] Assigning canary to centraluseuap #17517

Merged
merged 2 commits into from
Dec 28, 2020
Merged

[TA] Assigning canary to centraluseuap #17517

merged 2 commits into from
Dec 28, 2020

Conversation

maririos
Copy link
Member

@maririos maririos commented Dec 14, 2020

@maririos
Copy link
Member Author

/azp run net - textanalytics - tests-weekly

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@maririos maririos requested a review from benbp December 14, 2020 23:50
@Azure Azure deleted a comment from azure-pipelines bot Dec 14, 2020
@Azure Azure deleted a comment from azure-pipelines bot Dec 14, 2020
@maririos
Copy link
Member Author

/azp run net - textanalytics - tests-weekly

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@maririos
Copy link
Member Author

/azp run net - textanalytics - tests-weekly

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@maririos
Copy link
Member Author

/azp run net - textanalytics

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@maririos maririos marked this pull request as ready for review December 15, 2020 00:57
SubscriptionConfiguration: $(sub-config-azure-cloud-test-resources)
Canary:
SubscriptionConfiguration: $(sub-config-azure-cloud-test-resources)
Location: 'centraluseuap'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want it, I was thinking of adding a CanaryLocation parameter to avoid the need for this, but also wanted to avoid too much parameter bloat at the same time.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry Ben. I forgot about this PR before I went on vacation.
I will prefer that, so we don't have duplication of the other clouds or configuration in each library.
Do you envision that other clouds would like to have their specific Location too? or only applies for Canary

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going to merge this PR as is to unblock the build.

@maririos
Copy link
Member Author

/azp run net - textanalytics - tests-weekly

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@maririos maririos merged commit 1588b45 into Azure:master Dec 28, 2020
@maririos maririos self-assigned this Dec 28, 2020
@maririos maririos deleted the weekly branch February 8, 2021 19:58
annelo-msft pushed a commit to annelo-msft/azure-sdk-for-net that referenced this pull request Feb 17, 2021
* assigning canary to centraluseuap

* override the whole thing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cognitive services not available in eastus2euap for Canary weely tests
2 participants