Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DedicatedHostGroup.properties.supportAutomaticPlacement default to false #17224

Merged
merged 2 commits into from
Dec 15, 2020

Conversation

dochung4
Copy link
Contributor

@dochung4 dochung4 commented Nov 29, 2020

Swagger PR: Azure/azure-rest-api-specs#11697

Dedicated host group automatic placement feature is currently in a limited public preview, available in a few regions for whitelisted subscriptions. It is planned to be GA'ed in some public regions in December. The initial plan was to default DedicatedHostGroup.properties.supportAutomaticPlacement to true, but recently we have agreed to default the value to false as we GA. Changing the default to false has already been made on the service side.

This PR updates only the description to the "supportAutomaticPlacement" property.

@YalinLi0312
Copy link
Member

@dochung4 Could you fix the failed CI tests?

@dochung4
Copy link
Contributor Author

dochung4 commented Dec 1, 2020

@dochung4 Could you fix the failed CI tests?

@YalinLi0312 , can you please share the log for the failure? I am not able to find it.

@dochung4
Copy link
Contributor Author

dochung4 commented Dec 7, 2020

@dochung4 Could you fix the failed CI tests?

@YalinLi0312 , can you please share the log for the failure? I am not able to find it.

@YalinLi0312 , is there any update?

@YalinLi0312
Copy link
Member

YalinLi0312 commented Dec 10, 2020

@dochung4 Please:

  • Update release notes in src/Microsoft.Azure.Management.Compute.csproj
  • Update the API tags in Az.Sdk.props if there's an API-version update
  • Make sure have proper test coverage

@dochung4
Copy link
Contributor Author

@dochung4 Please:

  • Update release notes in src/Microsoft.Azure.Management.Compute.csproj
  • Update the API tags in Az.Sdk.props if there's an API-version update
  • Make sure have proper test coverage
  • Updated Microsoft.Azure.Management.Compute.csproj
  • There is no API-version update
  • The existing test TestNonZonalDedicatedHostGroupInstanceViewAndAutomaticPlacement() already tests the property.

@YalinLi0312
Copy link
Member

/check-enforcer reset

@YalinLi0312
Copy link
Member

/check-enforcer override

@YalinLi0312
Copy link
Member

/check-enforcer reset

@YalinLi0312 YalinLi0312 reopened this Dec 15, 2020
@YalinLi0312 YalinLi0312 merged commit 5c3e5ef into Azure:master Dec 15, 2020
annelo-msft pushed a commit to annelo-msft/azure-sdk-for-net that referenced this pull request Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants