Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Langauage Settings File #14922

Merged
merged 1 commit into from
Sep 4, 2020
Merged

Update Langauage Settings File #14922

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion eng/scripts/Language-Settings.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,8 @@ function Publish-dotnet-GithubIODocs ()
Write-Host "DocDir $($Item)"
Write-Host "PkgName $($PkgName)"
Write-Host "DocVersion $($DocVersion)"
Upload-Blobs -DocDir "$($Item)" -PkgName $PkgName -DocVersion $DocVersion
$releaseTag = RetrieveReleaseTag "Nuget" $PublicArtifactLocation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot of variables being accessed in this function that aren't passed in. How do we ensure everything is setup correctly before we call this?

Copy link
Member Author

@chidozieononiwu chidozieononiwu Sep 4, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will have to import eng\common\scripts\artifact-metadata-parsing.ps1 in common.ps1 for this to work. That should work. Bit Ill have it tested when submitting the tools PR.

But these changes can go in because its currently not connected to anything. Its just that the code on the other side is in flux and I need to keep updating.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are trying to keep things all updated you should also update PackageInfoFromPackageFile to add the ReleaseTag

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am not calling the PackageInfoFromPackageFile in this file just yet.

Upload-Blobs -DocDir "$($Item)" -PkgName $PkgName -DocVersion $DocVersion -ReleaseTag $releaseTag
}
else
{
Expand Down