Fix bug with Volume.MountTarget due to type mistmach in swagger #11825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isra-fel
reviewed
May 6, 2020
| @@ -13,8 +13,8 @@ | |||
| <PackageTags>MicrosoftAzure Management;NetApp</PackageTags> | |||
| <PackageReleaseNotes> | |||
| <
There was a problem hiding this comment.
Hi, I think you need to bump up to 2.0.0 for the breaking change, unless of course the previous version wouldn't work at all.
Besides, please also update the 1.5.0 in this file
There was a problem hiding this comment.
I was not sure about that since this is a bugfix for a broken functionality. I am happy to bump to 2.0. if you prefer.
isra-fel
added
Mgmt
|
Sorry I didn't make this clear. If the function was broken then it's definitely safe to just increment the patch version. Let me do this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue with volume where Volume.MountTarget property was null since it was not correctly deserialized in generated client code due to swagger issue.
API swagger PR Azure/azure-rest-api-specs#9294