-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for GenerateId max length #11659
Conversation
Is the goal here to limit the final ID length? What about the following signature
? |
@pakrym - You suggestion on the signature looks good too. But that means there needs to be logic about calculating the length of the prefix and then determining the random number range in the test framework. Do you want to go that route? Also I see the gates are failing. Do you have any idea why? |
you can make in simpler and do (prefix + Random.Next()).Substing(maxLenght)
Trailing whitespace somewhere. SA1028: Code should not contain trailing whitespace |
@pakrym - Unfortunately I don't get the option to reply to your conversations here so making a new comment each time. I like your idea and I will change the code and update the PR. I currently have the .substring in my code. Makes sense to just move the logic to the test framework. |
4ce52f4
to
1530169
Compare
1530169
to
6b73296
Compare
6b73296
to
5cb976c
Compare
Fix output-folder (Azure#11659)
… testframework