Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PolicyInsights] Add trigger evaluation methods #10688

Merged
merged 2 commits into from
Mar 23, 2020
Merged

[PolicyInsights] Add trigger evaluation methods #10688

merged 2 commits into from
Mar 23, 2020

Conversation

pilor
Copy link
Contributor

@pilor pilor commented Mar 18, 2020

Generating off the latest PolicyInsights swagger spec. This adds methods for triggering compliance evaluation on a scope and adds policy entity version columns to policyStates query responses.

@pilor
Copy link
Contributor Author

pilor commented Mar 18, 2020

@calecarter FYI

@isra-fel isra-fel self-assigned this Mar 19, 2020
@isra-fel isra-fel added Mgmt This issue is related to a management-plane library. needs-review labels Mar 19, 2020
calecarter
calecarter approved these changes Mar 19, 2020
View reviewed changes
Copy link
Contributor

@calecarter calecarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

isra-fel
isra-fel suggested changes Mar 20, 2020
View reviewed changes
Copy link
Member

@isra-fel isra-fel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The generated code looks good to me, but it seems some tests are failing because sub id cannot be found in the recordings, e.g. https://github.com/Azure/azure-sdk-for-net/pull/10688/files#diff-812a913339e9ce75af8516e7a5973d4fR71

@pilor could you try recording them again? Thanks

@isra-fel isra-fel assigned pilor and unassigned isra-fel Mar 20, 2020
@pilor
Copy link
Contributor Author

pilor commented Mar 20, 2020

The generated code looks good to me, but it seems some tests are failing because sub id cannot be found in the recordings, e.g. https://github.com/Azure/azure-sdk-for-net/pull/10688/files#diff-812a913339e9ce75af8516e7a5973d4fR71

@pilor could you try recording them again? Thanks

Yeah, I was trying to solve this yesterday. The "SubscriptionId" only gets persisted in the recording when I run the tests individually. When run together (in VS or via the dotnet command line) it is not persisted. I'll run each individually for now to unblock but its odd behavior.

@pilor pilor removed their assignment Mar 20, 2020
@pilor
Copy link
Contributor Author

pilor commented Mar 20, 2020

@isra-fel test recording problem has been fixed

@isra-fel isra-fel merged commit 72280c3 into Azure:master Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isra-fel isra-fel isra-fel approved these changes

@calecarter calecarter calecarter approved these changes

@erich-wang erich-wang Awaiting requested review from erich-wang

Assignees
No one assigned
Labels
Mgmt This issue is related to a management-plane library.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pilor @isra-fel @calecarter