Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Identity] Change expires_on precendence for IMDS #8591

Merged
merged 1 commit into from
Apr 28, 2020

Conversation

sophiajt
Copy link
Contributor

This adds the IMDS expires_on precedence fix that was rolled into 1.0.3 into the current preview as well.

This allows us to use expires_on, if available, if we're using IMDS. Previously, we would only use expires_in, which meant that under some conditions, we wouldn't have an updated expiration of the token.

@sophiajt sophiajt requested a review from daviwil April 28, 2020 22:13
@sophiajt sophiajt requested a review from schaabs as a code owner April 28, 2020 22:13
@sophiajt sophiajt changed the title Change expires_on precendence for IMDS [Identity] Change expires_on precendence for IMDS Apr 28, 2020
Copy link
Contributor

@daviwil daviwil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤘

@mitchdenny mitchdenny merged commit 7dc274d into Azure:master Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants