You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
ramya-rao-a
merged 5 commits into
Azure:master
from
AnthonyMacKinnon:fix-crypto-importOct 23, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Referencing packages that import crypto in a Node project causes the following warnings on start:
[DEP0091] DeprecationWarning: crypto.DEFAULT_ENCODING is deprecated.
[DEP0010] DeprecationWarning: crypto.createCredentials is deprecated. Use tls.createSecureContext instead.
[DEP0011] DeprecationWarning: crypto.Credentials is deprecated. Use tls.SecureContext instead.
Assuming this gets merged, do we need to make a separate PR for the @next (v12) version as well or is the plan to eventually merge changes from master?
Thank you so much for fixing this, @AnthonyMacKinnon.
We keep the v12(feature/storage branch) in sync with the master by frequently merging the master branch.
Looks like the changes in this PR cover all the instances of * as crypto in the feature/storage branch as well. Hence, no need to make a separate PR for v12.
ClientThis issue points to a problem in the data-plane of the library.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AnthonyMacKinnon
requested review from
HarshaNalluru,
jeremymeng,
jiacfan,
sophiajt,
ramya-rao-a,
sadasant,
vinjiang and
XiaoningLiu
as code owners
HarshaNalluru
added
the
Client
Referencing packages that import
cryptoin a Node project causes the following warnings on start:For more detail, see nodejs/node#23203.