[Identity] Rethrow AuthenticationErrors in DeviceCodeCredential poll loop #5430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chradek
approved these changes
Oct 7, 2019
sophiajt
approved these changes
Oct 7, 2019
|
Thanks all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes an issue in
DeviceCodeCredentialwhere an unexpectedAuthenticationErrorresponse would not break the polling loop, causing the loop to poll indefinitely. I ran across this issue because I was trying to authenticate with an AAD App Registration that was not configured as a "public client" so aninvalid_clienterror was being returned. The error-checking switch statement was not looking for this specific error type nor did it have adefaultcase, so the error was ignored.The fix is to add a
defaultcase which rethrows any error type that we aren't explicitly checking for.