Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Changelog and bug fixes #27072

Merged
merged 4 commits into from
Sep 11, 2023

Conversation

v1k1
Copy link
Contributor

@v1k1 v1k1 commented Sep 11, 2023

Packages impacted by this PR

@azure/cosmos

Describe the problem that is addressed by this PR

  • Added changelog entries for v4.0.0 release.
  • Moved logic for addition of getClientConfig from ClientContext to DiagnosticNodeInternal, so that all such logic is at one place.
  • In case of exception, the logic to add request payload to diagnostic (with appropriate diagnostic level) was missing. added that.
  • Added test case for verifying scope of diagnostic level is limited to CosmosClient instance.

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Are there test cases added in this PR? (If not, why?)

Yes

Provide a list of related PRs (if any)

Command used to generate this PR:**(Applicable only to SDK release request PRs)

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

azure-cosmos

@sajeetharan sajeetharan merged commit 0237f04 into Azure:main Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants