Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration @azure/cosmos ci pipeline to run on windows-2022 agent pool. #24935

Merged
merged 2 commits into from
Feb 21, 2023

Conversation

v1k1
Copy link
Contributor

@v1k1 v1k1 commented Feb 21, 2023

Packages impacted by this PR

@azure/cosmos

Issues associated with this PR

Describe the problem that is addressed by this PR

Agent pool in eng\pipelines\templates\stages\platform-matrix.json has been migrated to windows-2022, from windows-2019. This caused tests to skip for @azure/cosmos which uses non standard file eng\pipelines\templates\stages\cosmos-sdk-client.yml instead of eng\pipelines\templates\stages\archetype-sdk-client.yml. We are currently planning to move to archetype-sdk-client.yml

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Are there test cases added in this PR? (If not, why?)

NA

Provide a list of related PRs (if any)

Command used to generate this PR:**(Applicable only to SDK release request PRs)

Checklists

  • Added impacted package name to the issue description
  • Does this PR needs any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here)
  • Added a changelog (if necessary)

@v1k1
Copy link
Contributor Author

v1k1 commented Feb 21, 2023

/azp run js - cosmosdb - ci

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@v1k1 v1k1 changed the title Migration @azure/cosmos ci pipeline to run on windows-2020 agent pool. Migration @azure/cosmos ci pipeline to run on windows-2022 agent pool. Feb 21, 2023
@v1k1
Copy link
Contributor Author

v1k1 commented Feb 21, 2023

/azp run js - cosmosdb - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@v1k1 v1k1 force-pushed the feature/pipeline-jobmatrix-windows19 branch from 42b25fd to 1121708 Compare February 21, 2023 12:04
@v1k1 v1k1 marked this pull request as ready for review February 21, 2023 12:06
@v1k1
Copy link
Contributor Author

v1k1 commented Feb 21, 2023

/azp run js - cosmosdb - ci

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@sajeetharan sajeetharan merged commit d585d8a into Azure:main Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants