Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyvault trigger when updating eng/common/testproxy #24774

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

scbedd
Copy link
Member

@scbedd scbedd commented Feb 7, 2023

We auto-target test-utils, which is a good barometer, but I am only comfortable with merging proxy changes if I can see that at least one real library in each repo really works.

…so that I can avoid manually queueing a verification build
@scbedd scbedd added the Central-EngSys This issue is owned by the Engineering System team. label Feb 7, 2023
@scbedd scbedd requested a review from ckairen as a code owner February 7, 2023 23:17
@scbedd scbedd self-assigned this Feb 7, 2023
@scbedd scbedd requested a review from benbp as a code owner February 7, 2023 23:17
@ghost ghost added the KeyVault label Feb 7, 2023
@scbedd scbedd changed the title Add trigger when updating eng/common/testproxy Add keyvault trigger when updating eng/common/testproxy Feb 7, 2023
Copy link
Member

@HarshaNalluru HarshaNalluru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good

@scbedd scbedd merged commit 47be222 into Azure:main Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team. KeyVault
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants