-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move remaining dataplane packages - batch3 #2240
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weshaggard
approved these changes
Apr 15, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending my questions on Azure/azure-rest-api-specs#5644 this PR looks good.
weshaggard
approved these changes
Apr 15, 2019
kpajdzik
approved these changes
Apr 15, 2019
KarishmaGhiya
force-pushed
the
moveArmInBulk3
branch
from
April 15, 2019 22:40
499797f
to
efb1f4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving following dataplane packages from packages@Azure and putting them under an
sdk
directory:A few changes that have been made:
lib
has been renamed tosrc
lib
have been updated tosrc
packages/@azure/arm-appservice
) to the new structure pathsdk/applicationservice/arm-appservice
to follow the structure sdk/servicename/packagenamePlease review Azure/azure-rest-api-specs#5644 as well
Please tag the required reviewers for the above dataplane packages
@salameer @daschult @kpajdzik @Azure/azure-sdk-eng