Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move remaining dataplane packages - batch3 #2240

Merged
merged 30 commits into from
Apr 15, 2019

Conversation

KarishmaGhiya
Copy link
Member

@KarishmaGhiya KarishmaGhiya commented Apr 13, 2019

Moving following dataplane packages from packages@Azure and putting them under an sdk directory:
image
A few changes that have been made:

  • The source code directory lib has been renamed to src
  • All the links in various files referencing lib have been updated to src
  • The paths of all the data-plane package under a service have been updated (eg: packages/@azure/arm-appservice) to the new structure path sdk/applicationservice/arm-appservice to follow the structure sdk/servicename/packagename
  • All the corresponding links in different files like package.json, etc have also been updated for the new structure path
  • I have also updated the path in README.md (typescript) for azure-rest-api-specs.

Please review Azure/azure-rest-api-specs#5644 as well

Please tag the required reviewers for the above dataplane packages
@salameer @daschult @kpajdzik @Azure/azure-sdk-eng

Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending my questions on Azure/azure-rest-api-specs#5644 this PR looks good.

@KarishmaGhiya KarishmaGhiya merged commit 763eb48 into Azure:master Apr 15, 2019
@KarishmaGhiya KarishmaGhiya deleted the moveArmInBulk3 branch April 17, 2019 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants