Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ReleasePR @azure/arm-security] Update alertsSuppressionRules.json #21380

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions common/config/rush/pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 1 addition & 12 deletions sdk/security/arm-security/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ API spec for Microsoft.Security (Azure Security Center) resource provider

[Source code](https://github.com/Azure/azure-sdk-for-js/tree/main/sdk/security/arm-security) |
[Package (NPM)](https://www.npmjs.com/package/@azure/arm-security) |
[API reference documentation](https://docs.microsoft.com/javascript/api/@azure/arm-security?view=azure-node-preview) |
[API reference documentation](https://docs.microsoft.com/javascript/api/@azure/arm-security) |
[Samples](https://github.com/Azure-Samples/azure-samples-js-management)

## Getting started
Expand All @@ -16,8 +16,6 @@ API spec for Microsoft.Security (Azure Security Center) resource provider
- [LTS versions of Node.js](https://nodejs.org/about/releases/)
- Latest versions of Safari, Chrome, Edge and Firefox.

See our [support policy](https://github.com/Azure/azure-sdk-for-js/blob/main/SUPPORT.md) for more details.

### Prerequisites

- An [Azure subscription][azure_sub].
Expand Down Expand Up @@ -51,17 +49,8 @@ For more information about how to create an Azure AD Application check out [this
```javascript
const { SecurityCenter } = require("@azure/arm-security");
const { DefaultAzureCredential } = require("@azure/identity");
// For client-side applications running in the browser, use InteractiveBrowserCredential instead of DefaultAzureCredential. See https://aka.ms/azsdk/js/identity/examples for more details.

const subscriptionId = "00000000-0000-0000-0000-000000000000";
const client = new SecurityCenter(new DefaultAzureCredential(), subscriptionId);

// For client-side applications running in the browser, use this code instead:
// const credential = new InteractiveBrowserCredential({
// tenantId: "<YOUR_TENANT_ID>",
// clientId: "<YOUR_CLIENT_ID>"
// });
// const client = new SecurityCenter(credential, subscriptionId);
```


Expand Down
8 changes: 4 additions & 4 deletions sdk/security/arm-security/_meta.json
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
{
"commit": "3c1da29166fe1306071c939ac1344b092bafd0ce",
"commit": "880394b28e0f4e7925f4ecb3edc46b651ab58129",
"readme": "specification/security/resource-manager/readme.md",
"autorest_command": "autorest --version=3.7.3 --typescript --modelerfour.lenient-model-deduplication --head-as-boolean=true --license-header=MICROSOFT_MIT_NO_VERSION --generate-test --typescript-sdks-folder=D:\\work\\azure-sdk-for-js ..\\azure-rest-api-specs\\specification\\security\\resource-manager\\readme.md --use=@autorest/typescript@6.0.0-alpha.18.20220329.1 --generate-sample=true",
"autorest_command": "autorest --version=3.7.3 --typescript --modelerfour.lenient-model-deduplication --head-as-boolean=true --license-header=MICROSOFT_MIT_NO_VERSION --generate-test --typescript-sdks-folder=/mnt/vss/_work/1/s/azure-sdk-for-js ../azure-rest-api-specs/specification/security/resource-manager/readme.md --use=@autorest/typescript@6.0.0-alpha.16.20220105.1",
"repository_url": "https://github.com/Azure/azure-rest-api-specs.git",
"release_tool": "@azure-tools/js-sdk-release-tools@2.2.1",
"use": "@autorest/typescript@6.0.0-alpha.18.20220329.1"
"release_tool": "@azure-tools/js-sdk-release-tools@2.2.6",
"use": "@autorest/typescript@6.0.0-alpha.16.20220105.1"
}
34 changes: 9 additions & 25 deletions sdk/security/arm-security/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"sdk-type": "mgmt",
"author": "Microsoft Corporation",
"description": "A generated SDK for SecurityCenter.",
"version": "5.0.1",
"version": "5.0.2",
"engines": {
"node": ">=12.0.0"
},
Expand All @@ -29,13 +29,13 @@
"types": "./types/arm-security.d.ts",
"devDependencies": {
"@microsoft/api-extractor": "^7.18.11",
"@rollup/plugin-commonjs": "^21.0.1",
"@rollup/plugin-json": "^4.1.0",
"@rollup/plugin-multi-entry": "^4.1.0",
"@rollup/plugin-node-resolve": "^13.1.3",
"@rollup/plugin-commonjs": "11.0.2",
"@rollup/plugin-json": "^4.0.0",
"@rollup/plugin-multi-entry": "^3.0.0",
"@rollup/plugin-node-resolve": "^8.0.0",
"mkdirp": "^1.0.4",
"rollup": "^2.66.1",
"rollup-plugin-sourcemaps": "^0.6.3",
"rollup": "^1.16.3",
"rollup-plugin-sourcemaps": "^0.4.2",
"typescript": "~4.2.0",
"uglify-js": "^3.4.9",
"rimraf": "^3.0.0",
Expand Down Expand Up @@ -98,21 +98,5 @@
"docs": "echo skipped"
},
"sideEffects": false,
"//metadata": {
"constantPaths": [
{
"path": "src/securityCenter.ts",
"prefix": "packageDetails"
}
]
},
"autoPublish": true,
"//sampleConfiguration": {
"productName": "",
"productSlugs": [
"azure"
],
"disableDocsMs": true,
"apiRefLink": "https://docs.microsoft.com/javascript/api/@azure/arm-security?view=azure-node-preview"
}
}
"autoPublish": true
}
78 changes: 72 additions & 6 deletions sdk/security/arm-security/rollup.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,62 @@ import json from "@rollup/plugin-json";

import nodeBuiltins from "builtin-modules";

/**
* Gets the proper configuration needed for rollup's commonJS plugin for @opentelemetry/api.
*
* NOTE: this manual configuration is only needed because OpenTelemetry uses an
* __exportStar downleveled helper function to declare its exports which confuses
* rollup's automatic discovery mechanism.
*
* @returns an object reference that can be `...`'d into your cjs() configuration.
*/
export function openTelemetryCommonJs() {
const namedExports = {};

for (const key of [
"@opentelemetry/api",
"@azure/core-tracing/node_modules/@opentelemetry/api"
]) {
namedExports[key] = [
"SpanKind",
"TraceFlags",
"getSpan",
"setSpan",
"SpanStatusCode",
"getSpanContext",
"setSpanContext"
];
}

const releasedOpenTelemetryVersions = ["0.10.2", "1.0.0-rc.0"];

for (const version of releasedOpenTelemetryVersions) {
namedExports[
// working around a limitation in the rollup common.js plugin - it's not able to resolve these modules so the named exports listed above will not get applied. We have to drill down to the actual path.
`../../../common/temp/node_modules/.pnpm/@opentelemetry/api@${version}/node_modules/@opentelemetry/api/build/src/index.js`
] = [
"SpanKind",
"TraceFlags",
"getSpan",
"setSpan",
"StatusCode",
"CanonicalCode",
"getSpanContext",
"setSpanContext"
];
}

return namedExports;
}

// #region Warning Handler

/**
* A function that can determine whether a rollup warning should be ignored. If
* A function that can determine whether a rollupwarning should be ignored. If
* the function returns `true`, then the warning will not be displayed.
*/

function ignoreNiseSinonEval(warning) {
function ignoreNiseSinonEvalWarnings(warning) {
return (
warning.code === "EVAL" &&
warning.id &&
Expand All @@ -30,14 +78,17 @@ function ignoreNiseSinonEval(warning) {
);
}

function ignoreChaiCircularDependency(warning) {
function ignoreChaiCircularDependencyWarnings(warning) {
return (
warning.code === "CIRCULAR_DEPENDENCY" &&
warning.importer && warning.importer.includes("node_modules/chai") === true
);
}

const warningInhibitors = [ignoreChaiCircularDependency, ignoreNiseSinonEval];
const warningInhibitors = [
ignoreChaiCircularDependencyWarnings,
ignoreNiseSinonEvalWarnings
];

/**
* Construct a warning handler for the shared rollup configuration
Expand Down Expand Up @@ -71,7 +122,22 @@ function makeBrowserTestConfig() {
nodeResolve({
mainFields: ["module", "browser"]
}),
cjs(),
cjs({
namedExports: {
// Chai's strange internal architecture makes it impossible to statically
// analyze its exports.
chai: [
"version",
"use",
"util",
"config",
"expect",
"should",
"assert"
],
...openTelemetryCommonJs()
}
}),
json(),
sourcemaps()
//viz({ filename: "dist-test/browser-stats.html", sourcemap: true })
Expand Down Expand Up @@ -107,7 +173,7 @@ export function makeConfig(pkg, options) {
],
output: { file: "dist/index.js", format: "cjs", sourcemap: true },
preserveSymlinks: false,
plugins: [sourcemaps(), nodeResolve()]
plugins: [sourcemaps(), nodeResolve(), cjs()]
};

const config = [baseConfig];
Expand Down
38 changes: 19 additions & 19 deletions sdk/security/arm-security/src/models/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1971,9 +1971,9 @@ export type ComplianceResult = Resource & {
readonly resourceStatus?: ResourceStatus;
};

/** Azure Security Center is provided in two pricing tiers: free and standard, with the standard tier available with a trial period. The standard tier offers advanced security capabilities, while the free tier offers basic security features. */
/** Microsoft Defender for Cloud is provided in two pricing tiers: free and standard, with the standard tier available with a trial period. The standard tier offers advanced security capabilities, while the free tier offers basic security features. */
export type Pricing = Resource & {
/** The pricing tier value. Azure Security Center is provided in two pricing tiers: free and standard, with the standard tier available with a trial period. The standard tier offers advanced security capabilities, while the free tier offers basic security features. */
/** The pricing tier value. Microsoft Defender for Cloud is provided in two pricing tiers: free and standard, with the standard tier available with a trial period. The standard tier offers advanced security capabilities, while the free tier offers basic security features. */
pricingTier?: PricingTier;
/** The sub-plan selected for a Standard pricing configuration, when more than one sub-plan is available. Each sub-plan enables a set of security features. When not specified, full plan is applied. */
subPlan?: string;
Expand Down Expand Up @@ -3147,7 +3147,7 @@ export type ServerVulnerabilityProperties = AdditionalData & {
readonly vendorReferences?: VendorReference[];
};

/** The logic app action that should be triggered. To learn more about Security Center's Workflow Automation capabilities, visit https://aka.ms/ASCWorkflowAutomationLearnMore */
/** The logic app action that should be triggered. To learn more about Microsoft Defender for Cloud's Workflow Automation capabilities, visit https://aka.ms/ASCWorkflowAutomationLearnMore */
export type AutomationActionLogicApp = AutomationAction & {
/** Polymorphic discriminator, which specifies the different types this object can be */
actionType: "LogicApp";
Expand All @@ -3157,7 +3157,7 @@ export type AutomationActionLogicApp = AutomationAction & {
uri?: string;
};

/** The target Event Hub to which event data will be exported. To learn more about Security Center continuous export capabilities, visit https://aka.ms/ASCExportLearnMore */
/** The target Event Hub to which event data will be exported. To learn more about Microsoft Defender for Cloud continuous export capabilities, visit https://aka.ms/ASCExportLearnMore */
export type AutomationActionEventHub = AutomationAction & {
/** Polymorphic discriminator, which specifies the different types this object can be */
actionType: "EventHub";
Expand All @@ -3172,7 +3172,7 @@ export type AutomationActionEventHub = AutomationAction & {
connectionString?: string;
};

/** The Log Analytics Workspace to which event data will be exported. Security alerts data will reside in the 'SecurityAlert' table and the assessments data will reside in the 'SecurityRecommendation' table (under the 'Security'/'SecurityCenterFree' solutions). Note that in order to view the data in the workspace, the Security Center Log Analytics free/standard solution needs to be enabled on that workspace. To learn more about Security Center continuous export capabilities, visit https://aka.ms/ASCExportLearnMore */
/** The Log Analytics Workspace to which event data will be exported. Security alerts data will reside in the 'SecurityAlert' table and the assessments data will reside in the 'SecurityRecommendation' table (under the 'Security'/'SecurityCenterFree' solutions). Note that in order to view the data in the workspace, the Security Center Log Analytics free/standard solution needs to be enabled on that workspace. To learn more about Microsoft Defender for Cloud continuous export capabilities, visit https://aka.ms/ASCExportLearnMore */
export type AutomationActionWorkspace = AutomationAction & {
/** Polymorphic discriminator, which specifies the different types this object can be */
actionType: "Workspace";
Expand Down Expand Up @@ -3690,9 +3690,9 @@ export type ResourceStatus = string;

/** Known values of {@link PricingTier} that the service accepts. */
export enum KnownPricingTier {
/** Get free Azure security center experience with basic security features */
/** Get free Microsoft Defender for Cloud experience with basic security features */
Free = "Free",
/** Get the standard Azure security center experience with advanced security features */
/** Get the standard Microsoft Defender for Cloud experience with advanced security features */
Standard = "Standard"
}

Expand All @@ -3701,8 +3701,8 @@ export enum KnownPricingTier {
* {@link KnownPricingTier} can be used interchangeably with PricingTier,
* this enum contains the known values that the service supports.
* ### Known values supported by the service
* **Free**: Get free Azure security center experience with basic security features \
* **Standard**: Get the standard Azure security center experience with advanced security features
* **Free**: Get free Microsoft Defender for Cloud experience with basic security features \
* **Standard**: Get the standard Microsoft Defender for Cloud experience with advanced security features
*/
export type PricingTier = string;

Expand Down Expand Up @@ -4589,11 +4589,11 @@ export type Threats = string;

/** Known values of {@link AssessmentType} that the service accepts. */
export enum KnownAssessmentType {
/** Azure Security Center managed assessments */
/** Microsoft Defender for Cloud managed assessments */
BuiltIn = "BuiltIn",
/** User defined policies that are automatically ingested from Azure Policy to Azure Security Center */
/** User defined policies that are automatically ingested from Azure Policy to Microsoft Defender for Cloud */
CustomPolicy = "CustomPolicy",
/** User assessments pushed directly by the user or other third party to Azure Security Center */
/** User assessments pushed directly by the user or other third party to Microsoft Defender for Cloud */
CustomerManaged = "CustomerManaged",
/** An assessment that was created by a verified 3rd party if the user connected it to ASC */
VerifiedPartner = "VerifiedPartner"
Expand All @@ -4604,9 +4604,9 @@ export enum KnownAssessmentType {
* {@link KnownAssessmentType} can be used interchangeably with AssessmentType,
* this enum contains the known values that the service supports.
* ### Known values supported by the service
* **BuiltIn**: Azure Security Center managed assessments \
* **CustomPolicy**: User defined policies that are automatically ingested from Azure Policy to Azure Security Center \
* **CustomerManaged**: User assessments pushed directly by the user or other third party to Azure Security Center \
* **BuiltIn**: Microsoft Defender for Cloud managed assessments \
* **CustomPolicy**: User defined policies that are automatically ingested from Azure Policy to Microsoft Defender for Cloud \
* **CustomerManaged**: User assessments pushed directly by the user or other third party to Microsoft Defender for Cloud \
* **VerifiedPartner**: An assessment that was created by a verified 3rd party if the user connected it to ASC
*/
export type AssessmentType = string;
Expand Down Expand Up @@ -4971,9 +4971,9 @@ export type ExpandControlsEnum = string;

/** Known values of {@link ControlType} that the service accepts. */
export enum KnownControlType {
/** Azure Security Center managed assessments */
/** Microsoft Defender for Cloud managed assessments */
BuiltIn = "BuiltIn",
/** Non Azure Security Center managed assessments */
/** Non Microsoft Defender for Cloud managed assessments */
Custom = "Custom"
}

Expand All @@ -4982,8 +4982,8 @@ export enum KnownControlType {
* {@link KnownControlType} can be used interchangeably with ControlType,
* this enum contains the known values that the service supports.
* ### Known values supported by the service
* **BuiltIn**: Azure Security Center managed assessments \
* **Custom**: Non Azure Security Center managed assessments
* **BuiltIn**: Microsoft Defender for Cloud managed assessments \
* **Custom**: Non Microsoft Defender for Cloud managed assessments
*/
export type ControlType = string;

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -261,12 +261,10 @@ export class AdaptiveNetworkHardeningsImpl
},
enforceOperationSpec
);
const poller = new LroEngine(lro, {
return new LroEngine(lro, {
resumeFrom: options?.resumeFrom,
intervalInMs: options?.updateIntervalInMs
});
await poller.poll();
return poller;
}

/**
Expand Down
Loading