[Unified Recorder] Add sample unified recorder tests to template #18817

timovv · 2021-11-25T00:03:56Z

Resolves #18227.

Needs updates as result of API changes:

timovv · 2021-12-07T00:09:35Z

Running into this issue when creating recordings in browser:

To reproduce, try running TEST_MODE=record rushx test:browser in the template package.

Tried to add the dotenv shim to the shared rollup config (see the PR changes) to no avail, but might be doing something wrong. @HarshaNalluru said you might be able to weigh in, @witemple-msft?

common/tools/dev-tool/src/config/rollup.base.config.ts

timovv · 2021-12-09T01:27:15Z

Still not quite ready, some tests aren't passing on the browser. Going to take another look tomorrow.

…haNalluru/azure-sdk-for-js into timovv-branch

...configurationclient_functional_tests/recording_predetermined_setting_has_expected_value.json

...dings/browsers/core_v1_tests_using_unified_recorder/recording_storagequeue_create_queue.json

jeremymeng

Should any new recordings be removed now that we don't have storage tests?

timovv · 2021-12-15T18:34:19Z

Yup, thought I'd removed them already! Think I got caught by #19045 again. I'll fix it up.

witemple-msft

Removing my red review.

stale

…emplate

joheredi · 2021-12-17T16:06:10Z

sdk/template/template/src/configurationClient.ts

  bearerTokenAuthenticationPolicy,
-  createPipelineFromOptions,
-  InternalPipelineOptions
+  createPipelineFromOptions
 } from "@azure/core-http";


Not related to this PR, I didn't realize we are still using core-http in the template. I think we should update to corev2. Filed #19447 to track

joheredi · 2021-12-17T16:09:53Z

sdk/template/template/package.json

@@ -39,17 +39,17 @@
    "extract-api": "tsc -p . && api-extractor run --local",
    "format": "prettier --write --config ../../../.prettierrc.json --ignore-path ../../../.prettierignore \"src/**/*.ts\" \"test/**/*.ts\" \"samples-dev/**/*.ts\" \"*.{js,json}\"",
    "generate:client": "autorest --typescript ./swagger/README.md",
-    "integration-test:browser": "karma start --single-run",
-    "integration-test:node": "nyc mocha -r esm --require source-map-support/register --reporter ../../../common/tools/mocha-multi-reporter.js --timeout 5000000 --full-trace \"dist-esm/test/{,!(browser)/**/}/*.spec.js\"",
+    "integration-test:browser": "dev-tool run test:browser",


dev-tool run test:browser is a different script than the test:browser in line 48 right? Not a big deal but I was originally confused thinking this would end up in an infinite loop of "test:browser" -> "integration-test:browser" -> "test:browser".

I wonder if we can have a different name in dev-tool?

joheredi

It looks great! And changes to migrate an existing package seem straight forward which is great! Looking forward to try this out in a few packages once everything is merged in a single recorder package!

…emplate

sdk/template/template/package.json

…emplate

Review request for Microsoft.ContainerService to add version 2022-04-02-preview (Azure#18900) * Adds base for updating Microsoft.ContainerService from version preview/2022-03-02-preview to version 2022-04-02-preview * Updates readme * Updates API version in new specs and examples * update readme (Azure#18714) * add NetworkPluginMode to ManagedCluster (Azure#18735) * add NetworkPluginMode to ManagedCluster * add overlay example * remove example * only keep overlap as option * Add properties for apiserver-vnet-integration (Azure#18705) * Update for AKS trusted access feature (Azure#18708) * Update for AKS trusted access feature * fixup! Update for AKS trusted access feature * fixup! fixup! Update for AKS trusted access feature * fixup! fixup! fixup! Update for AKS trusted access feature * fixup! fixup! fixup! fixup! Update for AKS trusted access feature * fixup! fixup! fixup! fixup! fixup! Update for AKS trusted access feature * fixup! fixup! fixup! fixup! fixup! fixup! Update for AKS trusted access feature * fixup! fixup! fixup! fixup! fixup! fixup! fixup! Update for AKS trusted access feature * fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Update for AKS trusted access feature * fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Update for AKS trusted access feature * fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Update for AKS trusted access feature * fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Update for AKS trusted access feature * OSSKU supports Windows options (Azure#18706) * OSSKU supports Windows options * Add example Create Agent Pool with Windows OSSKU * Improve description about the default value * Improve the description to clarify * Improve description about default Windows OSSKU * add storageProfile into managedcluster (Azure#18817) Signed-off-by: Ji An Liu <jiliu8@microsoft.com> * capatalize NetworkPluginMode name (Azure#18884) * capatalize NetworkPluginMode name * capitalize in description * aks: add enableCustomCATrust in v20220402-preview api-version (Azure#18830) * aks: add enableCustomCATrust in v20220402-preview api-version * aks: add description of CustomCATrust * aks: fix typo, add DaemonSet to custom words list Co-authored-by: Mikolaj Umanski <mumanski@microsoft.com> * [AKS] Update on trustedaccess resource (Azure#18947) * Add paging for trusted access * update async state * fixup! update async state * Use enum for TrustedAccessRoleBinding's ProvisioningState (Azure#18950) Co-authored-by: Tyler Lloyd <tyler.lloyd@microsoft.com> Co-authored-by: gossion <guwe@microsoft.com> Co-authored-by: Dong Liu <doliu@microsoft.com> Co-authored-by: Shiqian Tao <62196586+ShiqianTao@users.noreply.github.com> Co-authored-by: Ji'an Liu <jiliu8@microsoft.com> Co-authored-by: Mikołaj Umański <mik.umanski@gmail.com> Co-authored-by: Mikolaj Umanski <mumanski@microsoft.com>

timovv requested a review from HarshaNalluru November 25, 2021 00:03

timovv requested a review from a team as a code owner November 25, 2021 00:03

ghost added the EngSys This issue is impacting the engineering system. label Nov 25, 2021

timovv added 2 commits December 6, 2021 09:50

Add sample unified recorder tests to template

5fe93bd

Fix lint issues

d52f4cf

timovv force-pushed the unified-recorder/18227-unified-recorder-in-template branch from 04daaec to 1eff9e6 Compare December 7, 2021 00:05

timovv requested review from benbp, deyaaeldeen, mikeharder, praveenkuttappan, weshaggard and witemple-msft as code owners December 7, 2021 00:05

timovv marked this pull request as draft December 7, 2021 00:06

deyaaeldeen reviewed Dec 7, 2021

View reviewed changes

common/tools/dev-tool/src/config/rollup.base.config.ts Outdated Show resolved Hide resolved

Fix tests to work in browser

eee8f21

timovv force-pushed the unified-recorder/18227-unified-recorder-in-template branch from 1eff9e6 to eee8f21 Compare December 9, 2021 00:09

timovv added 3 commits December 8, 2021 16:35

Provide environment variable export

a806c32

Make the new recorder use its own env export

bf68caa

Fix up the tests a little bit

e1b9139

HarshaNalluru requested review from maorleger, sadasant and jeremymeng December 9, 2021 22:20

WIP -- trying to fix browser tests

ff90778

timovv force-pushed the unified-recorder/18227-unified-recorder-in-template branch from 19f2a94 to ff90778 Compare December 10, 2021 00:01

HarshaNalluru added 4 commits December 10, 2021 09:54

load the env file by default

bf61f75

changelog

a774935

Merge branch 'harshan/load-env-by-default' of https://github.com/Hars…

368e8b5

…haNalluru/azure-sdk-for-js into timovv-branch

fix template project

b2a88fb

sadasant reviewed Dec 15, 2021

View reviewed changes

...configurationclient_functional_tests/recording_predetermined_setting_has_expected_value.json Show resolved Hide resolved

sadasant reviewed Dec 15, 2021

View reviewed changes

...dings/browsers/core_v1_tests_using_unified_recorder/recording_storagequeue_create_queue.json Outdated Show resolved Hide resolved

jeremymeng reviewed Dec 15, 2021

View reviewed changes

Remove recordings we don't need any more

6676616

HarshaNalluru mentioned this pull request Dec 15, 2021

[Unified Recorder] Features #15829

Closed

97 tasks

witemple-msft reviewed Dec 15, 2021

View reviewed changes

witemple-msft self-requested a review December 15, 2021 19:03

Merge branch 'main' into unified-recorder/18227-unified-recorder-in-t…

4217995

…emplate

timovv added the test-utils-recorder Label for the issues related to the common recorder label Dec 15, 2021

HarshaNalluru requested review from xirzec, JonathanCrd and KarishmaGhiya December 15, 2021 23:53

timovv mentioned this pull request Dec 16, 2021

[Unified Recorder] NoOpCredential helper #19387

Closed

Merge branch 'main' into unified-recorder/18227-unified-recorder-in-t…

76c7bab

…emplate

joheredi reviewed Dec 17, 2021

View reviewed changes

joheredi approved these changes Dec 17, 2021

View reviewed changes

timovv added 2 commits December 21, 2021 09:50

Merge branch 'main' into unified-recorder/18227-unified-recorder-in-t…

88f8624

…emplate

Updates to template based on new refactor

52ab72b

HarshaNalluru reviewed Dec 22, 2021

View reviewed changes

sdk/template/template/package.json Outdated Show resolved Hide resolved

New syntax for dev-tool run

9239f0d

HarshaNalluru mentioned this pull request Dec 29, 2021

[App Config] Migrate the tests to use the new unified recorder #18896

Closed

timovv added 3 commits January 4, 2022 10:27

Merge branch 'main' into unified-recorder/18227-unified-recorder-in-t…

ffe8cd9

…emplate

Formatting

c30f419

Merge branch 'main' into unified-recorder/18227-unified-recorder-in-t…

b089f40

…emplate

timovv enabled auto-merge (squash) January 10, 2022 22:00

timovv merged commit 3d3914b into Azure:main Jan 10, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Unified Recorder] Add sample unified recorder tests to template #18817

[Unified Recorder] Add sample unified recorder tests to template #18817

timovv commented Nov 25, 2021 •

edited

Loading

timovv commented Dec 7, 2021

timovv commented Dec 9, 2021 •

edited

Loading

jeremymeng left a comment

timovv commented Dec 15, 2021

witemple-msft left a comment

joheredi Dec 17, 2021

joheredi Dec 17, 2021

joheredi left a comment

[Unified Recorder] Add sample unified recorder tests to template #18817

[Unified Recorder] Add sample unified recorder tests to template #18817

Conversation

timovv commented Nov 25, 2021 • edited Loading

timovv commented Dec 7, 2021

timovv commented Dec 9, 2021 • edited Loading

jeremymeng left a comment

Choose a reason for hiding this comment

timovv commented Dec 15, 2021

witemple-msft left a comment

Choose a reason for hiding this comment

joheredi Dec 17, 2021

Choose a reason for hiding this comment

joheredi Dec 17, 2021

Choose a reason for hiding this comment

joheredi left a comment

Choose a reason for hiding this comment

timovv commented Nov 25, 2021 •

edited

Loading

timovv commented Dec 9, 2021 •

edited

Loading