Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post release automated changes for keyvault releases #18603

Merged

Conversation

azure-sdk
Copy link
Collaborator

Post release automated changes for azure-keyvault-admin

@ghost
Copy link

ghost commented Nov 9, 2021

Hello @azure-sdk!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@maorleger maorleger force-pushed the post-release-automation-keyvault-1184901 branch from 86d9fc5 to a825ca1 Compare November 9, 2021 20:46
@maorleger
Copy link
Member

Two things I had to manually do:

  1. I had to run node ./eng/tools/versioning/increment.js --artifact-name azure-keyvault-secrets --repo-root . for keyvault secrets because the perf-test was still pinned to the older version. IMO the perf tests is one place where you don't want to pin to a specific version - it makes incrementing harder, and we'd want to run it against the latest pre-release anyway
  2. Post release automated steps generated samples for Key Rotation which is in beta, so I had to manually rebase and edit those files out of the commit

@ramya-rao-a ramya-rao-a merged commit d6cf46b into Azure:main Dec 15, 2021
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-js that referenced this pull request Apr 22, 2022
[Hub Generated] Review request for Microsoft.MixedReality to add version stable/2021-01-01 (Azure#18603)

* Update Microsoft.MixedReality swagger to fix quality issues in s360

* Fixing linter issue

* Revert "Fixing linter issue"

This reverts commit 9d3b03a4aa7f742309c46277a7bf529f9f9a9088.

Co-authored-by: Ramón Argüelles-García <rgarcia@ntdev.microsoft.com>
@azure-sdk azure-sdk deleted the post-release-automation-keyvault-1184901 branch October 19, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants