Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rlc quickstart guideline #18503

Merged
merged 10 commits into from
Nov 15, 2021
Merged

Add rlc quickstart guideline #18503

merged 10 commits into from
Nov 15, 2021

Conversation

qiaozha
Copy link
Member

@qiaozha qiaozha commented Nov 3, 2021

No description provided.

dw511214992
dw511214992 reviewed Nov 5, 2021
View reviewed changes
documentation/LLC-quickstart.md Outdated Show resolved Hide resolved
documentation/LLC-quickstart.md Outdated Show resolved Hide resolved
@check-enforcer
Copy link

check-enforcer bot commented Nov 5, 2021

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run js - [service] - ci

joheredi
joheredi reviewed Nov 9, 2021
View reviewed changes
Copy link
Member

@joheredi joheredi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through the steps. In general it looks good, however there are a few missing steps that would prevent someone following getting a buildable package. I have added all my findings as comments.

documentation/LLC-quickstart.md Outdated Show resolved Hide resolved
documentation/LLC-quickstart.md Outdated Show resolved Hide resolved
documentation/LLC-quickstart.md Outdated Show resolved Hide resolved
documentation/LLC-quickstart.md Outdated Show resolved Hide resolved
documentation/LLC-quickstart.md Outdated Show resolved Hide resolved
documentation/LLC-quickstart.md Outdated Show resolved Hide resolved
documentation/LLC-quickstart.md Outdated Show resolved Hide resolved
documentation/LLC-quickstart.md Outdated Show resolved Hide resolved
documentation/LLC-quickstart.md Outdated Show resolved Hide resolved
documentation/LLC-quickstart.md Outdated Show resolved Hide resolved
@qiaozha
Copy link
Member Author

qiaozha commented Nov 12, 2021

I think most of the comments are resolved, @joheredi @dw511214992 Could you help to take a look again ? Thanks

@qiaozha qiaozha changed the title Add llc quickstart guideline Add rlc quickstart guideline Nov 12, 2021
@qiaozha
Copy link
Member Author

qiaozha commented Nov 15, 2021

/check-enforcer evaluate

@qiaozha
Copy link
Member Author

qiaozha commented Nov 15, 2021

/check-enforcer override

@qiaozha qiaozha merged commit e44e8a9 into main Nov 15, 2021
@qiaozha qiaozha deleted the add-llc-quickstart-guideline branch November 15, 2021 03:40
cochi2 added a commit that referenced this pull request Nov 15, 2021
@cochi2 @maorleger
@azure-sdk @benbp @scbedd @deyaaeldeen @chradek @sarangan12 @willmtemple @qiaozha @weshaggard @praveenkuttappan
Applying comments from API Review (#18662)
68337e8 
* Removing return response for Pause/Resume/Stop recording

* Removing validations

* Fixes after merge

* Added downloadToFile operation

* Added downloadToFile test

* Updating API MD file

* Fixing format auto

* Renaming files

* [KeyVault] - Move MHSM to resource group location (#18664)

Moving the Managed HSM to the same location as our resource group now that the
limits have been expanded.

* Add default cloud configuration values to source (#18653)

Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>

* simplify the commit history so that the patch can apply properly (#18665)

Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>

* Updating name for header

* [Event Hubs] Merge feature branch for buffered producer (#18590)

* [event-hubs] EventHubsBufferedProducerClient skeleton (#17761)

* temp transfer

* [event-hubs] initial EventHubBufferedProducerClient skeleton

* Change default value of BufferedCloseOptions.flush to true instead of false

* Reorder doc comment content for EventHubBufferedProducerClient

* remove eslint exception for @azure/azure-sdk/ts-naming-options in EventHubBufferedProducerClientOptions

* add enqueueEvent (singular) method

* update API view

* [WIP][event-hubs] EventHubBufferedProducerClient implementation (#18106)

* transfer

* [mock-hub] fix issue where calling stop() would not remove existing idle connection timeout watchers

* [event-hubs] reduce repetition in hubruntime.spec.ts tests

* Add support for flush,eventSuccess and eventError handlers, and backpressure to EventHubBufferedProducerClient

* add documentation and update API to align with .NET

* [Buffered Event Hubs Producer] Implements Parition Key to Partition ID mapping (#18331)

* [Buffered Event Hubs Producer] Implements Parition Key to Partition ID mapping

* fix the implementation

* factor out the hashing logic

* remove unused import

* the test pass but the implementation needs to be simplified

* simplified implementation

* address feedback

* address feedback

* fix format

* address feedback

Co-authored-by: chradek <51000525+chradek@users.noreply.github.com>

* [Event Hubs] Prepare release (#18672)

* [Event Hubs] Prepare release

* remove empty sections

* Node doesn't support some samples for smoke test (#18496)

* Node doesn't support some samples for smoke test

* [search-documents] reprocessed samples with exp. generator

Co-authored-by: Will Temple <will@wtemple.net>

* Add rlc quickstart guideline (#18503)

* add llc quickstart guideline

* update format

* add documentation about ci.yml

* update to resolve some comments

* update to resolve some comments

* update to resolve comments

* updates term

* update format

* update format

* Running Rush update

* Sync eng/common directory with azure-sdk-tools for PR 2265 (#18683)

* Improve devops logging for link checker

* Update eng/common/scripts/Verify-Links.ps1

Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com>
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>

* Build and test predefined set of packages only in identity pipelines (#18686)

* Build and test predefined set of packages only in identity pipelines

* Fixing playback testing

* Run rushx format

Co-authored-by: Maor Leger <maorleger@users.noreply.github.com>
Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>
Co-authored-by: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
Co-authored-by: chradek <51000525+chradek@users.noreply.github.com>
Co-authored-by: Sarangan Rajamanickam <sarajama@microsoft.com>
Co-authored-by: Will Temple <will@wtemple.net>
Co-authored-by: Qiaoqiao Zhang <55688292+qiaozha@users.noreply.github.com>
Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com>
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
Co-authored-by: praveenkuttappan <55455725+praveenkuttappan@users.noreply.github.com>
zihzhan-msft pushed a commit that referenced this pull request Nov 16, 2021
@cochi2 @maorleger
@azure-sdk @benbp @scbedd @deyaaeldeen @chradek @sarangan12 @willmtemple @qiaozha @weshaggard @praveenkuttappan
Fixing naming for Download returning methods. (#18703)
85893a8 
* [KeyVault] - Move MHSM to resource group location (#18664)

Moving the Managed HSM to the same location as our resource group now that the
limits have been expanded.

* Add default cloud configuration values to source (#18653)

Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>

* simplify the commit history so that the patch can apply properly (#18665)

Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>

* [Event Hubs] Merge feature branch for buffered producer (#18590)

* [event-hubs] EventHubsBufferedProducerClient skeleton (#17761)

* temp transfer

* [event-hubs] initial EventHubBufferedProducerClient skeleton

* Change default value of BufferedCloseOptions.flush to true instead of false

* Reorder doc comment content for EventHubBufferedProducerClient

* remove eslint exception for @azure/azure-sdk/ts-naming-options in EventHubBufferedProducerClientOptions

* add enqueueEvent (singular) method

* update API view

* [WIP][event-hubs] EventHubBufferedProducerClient implementation (#18106)

* transfer

* [mock-hub] fix issue where calling stop() would not remove existing idle connection timeout watchers

* [event-hubs] reduce repetition in hubruntime.spec.ts tests

* Add support for flush,eventSuccess and eventError handlers, and backpressure to EventHubBufferedProducerClient

* add documentation and update API to align with .NET

* [Buffered Event Hubs Producer] Implements Parition Key to Partition ID mapping (#18331)

* [Buffered Event Hubs Producer] Implements Parition Key to Partition ID mapping

* fix the implementation

* factor out the hashing logic

* remove unused import

* the test pass but the implementation needs to be simplified

* simplified implementation

* address feedback

* address feedback

* fix format

* address feedback

Co-authored-by: chradek <51000525+chradek@users.noreply.github.com>

* [Event Hubs] Prepare release (#18672)

* [Event Hubs] Prepare release

* remove empty sections

* Node doesn't support some samples for smoke test (#18496)

* Node doesn't support some samples for smoke test

* [search-documents] reprocessed samples with exp. generator

Co-authored-by: Will Temple <will@wtemple.net>

* Add rlc quickstart guideline (#18503)

* add llc quickstart guideline

* update format

* add documentation about ci.yml

* update to resolve some comments

* update to resolve some comments

* update to resolve comments

* updates term

* update format

* update format

* Sync eng/common directory with azure-sdk-tools for PR 2265 (#18683)

* Improve devops logging for link checker

* Update eng/common/scripts/Verify-Links.ps1

Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com>
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>

* Build and test predefined set of packages only in identity pipelines (#18686)

* Build and test predefined set of packages only in identity pipelines

* Removed raw response from ContentDownloadResponse

* Changing name to RepeatanleContentDownloadResult

* Changed name to ContentDownloadResult

* Fixes after merging

Co-authored-by: Maor Leger <maorleger@users.noreply.github.com>
Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Co-authored-by: Ben Broderick Phillips <bebroder@microsoft.com>
Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>
Co-authored-by: Deyaaeldeen Almahallawi <dealmaha@microsoft.com>
Co-authored-by: chradek <51000525+chradek@users.noreply.github.com>
Co-authored-by: Sarangan Rajamanickam <sarajama@microsoft.com>
Co-authored-by: Will Temple <will@wtemple.net>
Co-authored-by: Qiaoqiao Zhang <55688292+qiaozha@users.noreply.github.com>
Co-authored-by: Wes Haggard <Wes.Haggard@microsoft.com>
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
Co-authored-by: praveenkuttappan <55455725+praveenkuttappan@users.noreply.github.com>
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-js that referenced this pull request Apr 8, 2022
CodeGen from PR 18503 in Azure/azure-rest-api-specs
479e0c6 
Add dapr AppInsights connection string (Azure#18503)

* Add dapr AppInsights connection string

* Remove the deprecation note for now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dw511214992 dw511214992 dw511214992 left review comments

@joheredi joheredi joheredi approved these changes

Assignees

@joheredi joheredi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qiaozha @joheredi @dw511214992