-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Service Bus] Support MaxMessageSizeInKilobytes #17953
Merged
HarshaNalluru
merged 30 commits into
Azure:main
from
HarshaNalluru:harshan/sb/isssue/17592
Oct 1, 2021
Merged
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
b7a15ca
Fix retry handling for Session Not Found errors
southpolesteve ca193b8
Update sdk/cosmosdb/cosmos/test/internal/session.spec.ts
southpolesteve 4b1a28d
Update CODEOWNERS for Application Insights (#17055)
omziv ac74691
MaxMessageSizeInKilobytes api
HarshaNalluru 5a3f61f
sample,test.env
HarshaNalluru ab38a7f
API Report
HarshaNalluru a92b562
add tests
HarshaNalluru c7216a3
finish the tests
HarshaNalluru 877e520
remove console.log
HarshaNalluru 5ae1497
arm template
HarshaNalluru 33c7a51
put .only to test in CI with limited tests
HarshaNalluru f591f89
minor test update
HarshaNalluru d3a1972
remove .only, add changelog
HarshaNalluru a484888
Update sdk/servicebus/service-bus/src/util/constants.ts
HarshaNalluru 3d44649
Merge branch 'harshan/sb/isssue/17592' of https://github.com/harshana…
HarshaNalluru 6ffc5c5
wrap text - changelog
HarshaNalluru 4f42563
maxMessageSizeInKilobytes: 256 by default for Standard namespaces
HarshaNalluru f0039e0
Revert "maxMessageSizeInKilobytes: 256 by default for Standard namesp…
HarshaNalluru 1233921
exclude "maxMessageSizeInKilobytes"
HarshaNalluru f312390
(Configurable only for Premium Tier Service Bus namespace.)
HarshaNalluru 1a90e13
Version 7.3.1-beta.1
HarshaNalluru e903476
update version at more places
HarshaNalluru 83c6be2
lock file
HarshaNalluru 393a3b9
Update sdk/servicebus/service-bus/CHANGELOG.md
HarshaNalluru 8b5b21b
dummy
HarshaNalluru 4dcc280
Merge branch 'main' of https://github.com/Azure/azure-sdk-for-js into…
HarshaNalluru 16a56b9
lock file
HarshaNalluru d8eccca
Merge branch 'harshan/sb/isssue/17592' of https://github.com/harshana…
HarshaNalluru b73e9cb
non optional in EntityProperties
HarshaNalluru 70b8d32
api report
HarshaNalluru File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
# Used in most tests. Retrieve this value from a service-bus namespace in the Azure Portal. | ||
SERVICEBUS_CONNECTION_STRING="<connection string>" | ||
|
||
# Used in a couple of tests | ||
SERVICEBUS_CONNECTION_STRING_PREMIUM="<connection string>" | ||
|
||
# Used to authenticate using Azure AD as a service principal for role-based authentication. | ||
AZURE_TENANT_ID=<AD tenant id or name> | ||
AZURE_CLIENT_ID=<ID of the user/service principal to authenticate as> | ||
AZURE_CLIENT_SECRET=<client secret used to authenticate to Azure AD> |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add the note about being configurable only for Premium and service version 2021-05 or higher for each property?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added that note("configurable only for Premium") for the
Create{Entity}Options
interfaces.Did not add the same for
{Entity}Properties
interface as that is used for output responses.How does it matter if the users can't configure the service version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The users can't configure the service version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like it should be configurable based on the TS guidelines - https://azure.github.io/azure-sdk/typescript_design.html#ts-service-versions-select-api-version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point.
Should I add this in a future PR, @ramya-rao-a?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#17972
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't we need to do this before releasing a new service version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ramya-rao-a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a scenario where the customer would want to intentionally use the older API version? If so, then we can make sure we allow that before GA
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we recommend that libraries that use the SDK pin to a specific API version. So we should probably support that before GA.