[Identity] Added suport for AZURE_MANAGED_IDENTITY_CLIENT_ID #17311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
christothes
reviewed
Aug 31, 2021
| @@ -4,6 +4,8 @@ | |||
|
|
|||
| ### Features Added | |||
|
|
|||
| - The `ManagedIdentityCredential` now suppports specifying the Client ID through the `AZURE_MANAGED_IDENTITY_CLIENT_ID` environment variable. | |||
There was a problem hiding this comment.
Should we use AZURE_CLIENT_ID instead (DAC already does this in its options)
There was a problem hiding this comment.
Using AZURE_CLIENT_ID would be a breaking change. Let me send you an email that @g2vinay sent last week.
There was a problem hiding this comment.
Oh - yes I remember it now.. Thanks!
|
Based on our emails, we’ve decided not to include this change. I’m closing this PR. |
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Jan 20, 2022
New Azure Virtual Network Manager API Version (Azure#17311) * add base api to new version folder for reviewer reference * add chenges for new api versiongit add . * adding changes for new api version * removing extra files left over from PR fix * fixing xmsIdentifierValidation errors * checks not running, changing text to retrigger * checks not running, changing text to retrigger * adding force delete and recursive delete parameters * add missing x-mx-paramter-location attributes, and fix warnings * adding force delete and recursive delete parameters * adding force delete and recursive delete parameters Co-authored-by: Jared Gorthy <jaredgorthy@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it so the ManagedIdentityCredential can receive the Client ID from the environment variables.
This design has not been approved yet.
Fixes #8436