Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LUIS Authoring Release Version 3.0 #16851

Closed
wants to merge 1 commit into from

Conversation

sarangan12
Copy link
Member

This PR will replace the PR #16720.

In this PR, I have regenerated the LUIS Authoring SDK.

  1. With this regeneration, the swagger service version is updated from 3.0-preview -> 3.0. The same has been reflected in README.md table.
  2. The version of the SDK is updated from 4.0.0-preview.3 -> 4.0.0-preview.4. There are breaking changes in this PR. But since this is a preview release, that should not be a problem. Note: I am not sure if the release is going to be a preview release. After discussion with @mariam606, I may update the version to 4.0.0.
  3. I have used the following command to regenerate the SDK:
autorest --typescript --license-header=MICROSOFT_MIT_NO_VERSION --typescript-sdks-folder=C:\Users\sarajama\Projects\azure-sdk-for-js --use=@microsoft.azure/autorest.typescript@4.4.1 --package-version=4.0.0-preview.4 --title=LUISAuthoringClient https://raw.githubusercontent.com/Azure/azure-rest-api-specs/350cb8b8ca52d093010395c52130a5723abf717e/specification/cognitiveservices/data-plane/LUIS/Authoring/readme.md --tag=authoring_3_0

Note: The above command uses a swagger that is still in PR stage and has not been merged (That is the reason for Do Not Merge label on this PR). Once the swagger PR is merged, I need to regenerate the SDK again and update this PR. At this point, this PR is to give an overall idea of the upcoming changes.

FYI - @ramya-rao-a @mariam606 @kayousef

@@ -2,7 +2,7 @@
"name": "@azure/cognitiveservices-luis-authoring",
"author": "Microsoft Corporation",
"description": "LUISAuthoringClient Library with typescript type definitions for node.js and browser.",
"version": "4.0.0-preview.3",
"version": "4.0.0-preview.4",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this has to be a GA because the endpoint version is a GA

@ramya-rao-a
Copy link
Contributor

There are tests for this package that would need to be run manually by the LUIS team and make any changes if needed.
It is better if the original PR #16720 is used for those purposes.

Please consider closing this and providing this PR as a pointer to the folks at #16720 as to how to re-generate the package

@sarangan12
Copy link
Member Author

Closing this PR. This will be used as reference only

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants