[Cred Scan] Generate fake key instead of putting directly in the test file #16700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
ellismg
approved these changes
Aug 2, 2021
ellismg
added a commit
to ellismg/azure-sdk-for-js
that referenced
this pull request
Aug 3, 2021
In Azure#16700 we updated our tests to generate the key we used for testing by doing a base64 conversion of a fixed string so we didn't have something that looked like a key embeded in source which was upsetting some static analysis tools. This casues a build break in the min/max testing where `btoa` can't be found when building the test. Since we have the correct runtime behavior in the test to only call `btoa` when we are not in a node-context we simply reference the dom library to appease the compiler.
ellismg
added a commit
that referenced
this pull request
Aug 4, 2021
In #16700 we updated our tests to generate the key we used for testing by doing a base64 conversion of a fixed string so we didn't have something that looked like a key embeded in source which was upsetting some static analysis tools. This casues a build break in the min/max testing where `btoa` can't be found when building the test. Since we have the correct runtime behavior in the test to only call `btoa` when we are not in a node-context we simply reference the dom library to appease the compiler.
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Nov 9, 2021
Move swagger json file out of definitions folder (Azure#16700) * IoT Central Public API 1.1-preview Oct Release (Azure#16514) * Add new 2.0-preview.1 version for IoT Central * fix typo on enum value * rollback 1.0 changes, applied 2.0-preview.1 * fix typo * remove non-used examples * fix style * update version from 2.0-preview.1 to 1.1-preview * update code review comments, fix patch consumes with json-patch support, fix examples for fileupload * add nextLink to collection of orgs * fix typo * fix wrong position of paging * fix the paging * add . to description * update default to use enum for api-version * add oct release with query, cde v2, device filter, device template filter, relationship, edge template, simplified template patching * update examples * fix lint error, model validation * fix missing type in examples, remove url format * fix ID case * fix id case * fix ID case * add iotc query language reference * fix typo * Move things out of definitions * remove ../ Co-authored-by: Johnson Yang <hayang@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would help reduce the noise in the cred scan report by striking off one complaint from the list of complaints.
https://dev.azure.com/azure-sdk/internal/_build?definitionId=1394&_a=summary