webpubsub-track2 #16570

colawwj · 2021-07-27T08:00:17Z

release for issue: https://github.com/Azure/sdk-release-request/issues/1713

deyaaeldeen · 2021-07-27T23:37:09Z

sdk/web-pubsub/arm-webpubsub/CHANGELOG.md

@@ -0,0 +1,14 @@
+## 0.1.0-beta.1 (2021-07-27)
+
+This is the first preview for the new version of the `@azure/arm-webpubsub` package that follows the new [guidelines for TypeScript SDKs](https://azure.github.io/azure-sdk/typescript_introduction.html) for Azure services.


I think the changelog should follow the standard format where it has some standard subsections: Features added, Key Bug Fixes, etc

@deyaaeldeen Could you show me where's the standard format ? like an example?

See subsections under https://github.com/Azure/azure-sdk-for-js/blob/main/sdk/textanalytics/ai-text-analytics/CHANGELOG.md#520-beta1-unreleased

deyaaeldeen

LGTM!

eng/ignore-links.txt

sdk/web-pubsub/arm-webpubsub/README.md

weshaggard · 2021-08-04T15:59:49Z

eng/ignore-links.txt

@@ -8,3 +8,5 @@ https://github.com/Azure/azure-sdk-for-js/tree/main/sdk/storage/storage-blob-cha
 https://github.com/Azure/azure-sdk-for-js/tree/main/sdk/storage/storage-blob-changefeed/samples/typescript
 https://github.com/Azure/azure-sdk-for-js/tree/main/sdk/storage/storage-blob-changefeed/test/
 https://github.com/Azure/azure-digital-twins/blob/private-preview/Documentation/how-to-manage-routes.md
+https://docs.microsoft.com/javascript/api/@azure/arm-webpubsub


@qiaozha We generally avoid putting things into the ignore-links.txt file. We have guidelines for handling links at http://aka.ms/azsdk/guideline/links.

Please make sure that you have an issue filed to remove these from this ignore file.

Sure. I have created issue #16776

weshaggard · 2021-08-04T16:00:35Z

sdk/web-pubsub/ci.yml

@@ -1,5 +1,3 @@
-# NOTE: Please refer to https://aka.ms/azsdk/engsys/ci-yaml before editing this file.


nit: Any particular reason this comment was removed?

That's removed by our automation tool. @colawwj Could you add it back? I will change the tool accordingly so that it won't remove this comment in the future.

Can you point me to the code that is writing this? I'd like to understand what automation we have that mutate these.

weshaggard · 2021-08-04T17:02:23Z

sdk/web-pubsub/arm-webpubsub/package.json

+  "sdk-type": "mgmt",
+  "author": "Microsoft Corporation",
+  "description": "A generated SDK for WebPubSubManagementClient.",
+  "version": "0.1.0-beta.1",


We generally don't have version numbers that start with 0 see https://azure.github.io/azure-sdk/policies_releases.html#javascript for versioning guidelines. We would typically start with "1.0.0-beta.1"

Thanks for sharing the link. I have a question to ask. When should we remove the beta.1 ? when our code generator GA or when the service itself get GA. This package's api version is a preview version, I guess the service still not GA yet.

We can cover this in the meeting I scheduled around versioning but in general we should make this when the code in the library is GA not necessarily when the service GA's. Although we don't GA a library unless the service apis we are calling are also GA.

Compute 2021-11-01 Release (Azure#17120) * compute folder with pre-population * fix examples folder * fix an example file * update compute to match last version * run prettier fix examples * change capitalization * Compute Swagger changes to include cross-region Restore Points scenarios (Azure#16570) * RRP changes in swagger * Fix conflicts * fix validations * Fix instance view * Revert "Compute Swagger changes to include cross-region Restore Points scenarios (Azure#16570)" (Azure#16663) This reverts commit 70a8729e86b30440cdd3c239272e31dff7f9627b. * sync with last version * add missing examples * suppress bodyTopLevelProperties * Add VMSS filter to List VMs (Azure#16813) * change1 for change file * change description * change description * add suppression for required properties * Revert "Add VMSS filter to List VMs (Azure#16813)" (Azure#16956) This reverts commit 231fd2260cb9e63ba16d8b15d405f3134fe612c1. * Remove impossible state from example (Azure#16544) * Downmerging change from Azure:main (Azure#16654) Co-authored-by: Avinash Akka <avakka@microsoft.com> * Added CVM settings for version 2021-11-01 (Azure#16622) * Added CVM settings * added examples * Add CMK examples * fixed typo * fixed file name * prettier check * removed a br * changed to VMDiskSecurityProfile * type as object * Added vm size properties for vm scale set (Azure#16723) * Added vm size properties * Added get examples * Added example for vm size properties * Added example for vm size properties Co-authored-by: Theodore Chang <thchan@microsoft.com> * Spec for ProtectedSettingsFromKeyVault and AllowExtensionOperations (Azure#16590) * KV changes * adding allowExtensionOperation * fixing examples * Add repairAction to auto repairs feature and update grace period to PT10M (Azure#16535) * Add timeCreated to properties for VM, VMSS, CR, DH resources (Azure#16539) * add creationTime to properties for VM, VMSS, CR, DH resources + remove required location for Resources * rename creationTime to timeCreated * examples for timeCreated * add minimum api-version to descriptions for timeCreated * add GetVirtualMachineScaleSet example * reformat example Co-authored-by: Chase Van Buskirk <cvanbuskirk@microsoft.com> * DedicatedHost Reboot Feature (Azure#16737) * added new feature to compute.json * added example for my feature * prettier check on the reboot example * fixed names of parameters in example file: * changed name to DedicatedHosts_reboot and moved change to where the other DH APIs are * added cloud error to the reboot * fixed default error, it was in the wrong spot * moved reboot to end of specs * moved older swagger files to 2021-11-01 * reverted previous commit * renamed reboot to restart as per sameers comment * updated description as per sameers comment * updated api version to 2021-11-01 per sameers comment * Adding the new paramaters zone/placementGroupId to forceRecoveryServiceFabricPlatformUpdateDomainWalk VMSS API (Azure#17041) * save (Azure#17091) Co-authored-by: Theodore Chang <thchan@microsoft.com> * Update compute.json (Azure#16482) When a customer tries to scale VMSS using Terraform, since the current definitions do not have publicIpPrefix property, the new VM will be assigned a random IP address which is outside the range of public Ip prefix. Customer has to resolve the issue by deleting the Vmss and recreating it. This PR tries to resolve the issue by adding the publicIpPrefix property in the JSON definition which is used to generate a request for VMSS update. More details about the issue can be found here - Azure/azure-rest-api-specs#10190 * add vmss filter to list (Azure#16957) * change1 for change file * change description * change description Co-authored-by: LexieXie <lexiexie@microsoft.com> * move Kashif's change to 2021-11-01 * Revert "Spec for ProtectedSettingsFromKeyVault and AllowExtensionOperations (Azure#16590)" (Azure#17121) This reverts commit 220cfd0638942c04275d69fd485ceb2da02a96d3. * fix CI failures, and run prettier on added examples * for credscan. change password example * Update readme.python.md * Compute Swagger changes to include cross-region Restore Points scenarios (Azure#16682) * RRP changes in swagger * Fix conflicts * fix validations * Fix instance view * change instance view * Fix example * Fix prettier * Fix and modify description * Review comments * make new api call long-running-operation * compute folder with pre-population * fix examples folder * fix an example file * update compute to match last version * run prettier fix examples * change capitalization * Compute Swagger changes to include cross-region Restore Points scenarios (Azure#16570) * RRP changes in swagger * Fix conflicts * fix validations * Fix instance view * Revert "Compute Swagger changes to include cross-region Restore Points scenarios (Azure#16570)" (Azure#16663) This reverts commit 70a8729e86b30440cdd3c239272e31dff7f9627b. * sync with last version * add missing examples * Add VMSS filter to List VMs (Azure#16813) * change1 for change file * change description * change description * Revert "Add VMSS filter to List VMs (Azure#16813)" (Azure#16956) This reverts commit 231fd2260cb9e63ba16d8b15d405f3134fe612c1. * Remove impossible state from example (Azure#16544) * Added CVM settings for version 2021-11-01 (Azure#16622) * Added CVM settings * added examples * Add CMK examples * fixed typo * fixed file name * prettier check * removed a br * changed to VMDiskSecurityProfile * type as object * Added vm size properties for vm scale set (Azure#16723) * Added vm size properties * Added get examples * Added example for vm size properties * Added example for vm size properties Co-authored-by: Theodore Chang <thchan@microsoft.com> * Spec for ProtectedSettingsFromKeyVault and AllowExtensionOperations (Azure#16590) * KV changes * adding allowExtensionOperation * fixing examples * Add repairAction to auto repairs feature and update grace period to PT10M (Azure#16535) * Add timeCreated to properties for VM, VMSS, CR, DH resources (Azure#16539) * add creationTime to properties for VM, VMSS, CR, DH resources + remove required location for Resources * rename creationTime to timeCreated * examples for timeCreated * add minimum api-version to descriptions for timeCreated * add GetVirtualMachineScaleSet example * reformat example Co-authored-by: Chase Van Buskirk <cvanbuskirk@microsoft.com> * DedicatedHost Reboot Feature (Azure#16737) * added new feature to compute.json * added example for my feature * prettier check on the reboot example * fixed names of parameters in example file: * changed name to DedicatedHosts_reboot and moved change to where the other DH APIs are * added cloud error to the reboot * fixed default error, it was in the wrong spot * moved reboot to end of specs * moved older swagger files to 2021-11-01 * reverted previous commit * renamed reboot to restart as per sameers comment * updated description as per sameers comment * updated api version to 2021-11-01 per sameers comment * Adding the new paramaters zone/placementGroupId to forceRecoveryServiceFabricPlatformUpdateDomainWalk VMSS API (Azure#17041) * save (Azure#17091) Co-authored-by: Theodore Chang <thchan@microsoft.com> * Update compute.json (Azure#16482) When a customer tries to scale VMSS using Terraform, since the current definitions do not have publicIpPrefix property, the new VM will be assigned a random IP address which is outside the range of public Ip prefix. Customer has to resolve the issue by deleting the Vmss and recreating it. This PR tries to resolve the issue by adding the publicIpPrefix property in the JSON definition which is used to generate a request for VMSS update. More details about the issue can be found here - Azure/azure-rest-api-specs#10190 * add vmss filter to list (Azure#16957) * change1 for change file * change description * change description Co-authored-by: LexieXie <lexiexie@microsoft.com> * move Kashif's change to 2021-11-01 * fix CI failures, and run prettier on added examples * Revert "Spec for ProtectedSettingsFromKeyVault and AllowExtensionOperations (Azure#16590)" (Azure#17121) This reverts commit 220cfd0638942c04275d69fd485ceb2da02a96d3. * for credscan. change password example * make new api call long-running-operation * Update readme.python.md * Compute Swagger changes to include cross-region Restore Points scenarios (Azure#16682) * RRP changes in swagger * Fix conflicts * fix validations * Fix instance view * change instance view * Fix example * Fix prettier * Fix and modify description * Review comments * update Repair action to enum and update readme * rebase to main since 2021-08-01 merged. update readme * update x-ms-enum name for RepairType * add default response to operations * update * put back 'required' tag for Resource.Location property and use a new object for VM_LIST return object * fix json format * update examples * run prettier on updated examples * update example for credScan * add VirtualMachineResource for toplevel property suppression. * lint diff errors * lint diff fix update * remove change for VMextensions.location bug * return readme file and examples before vm.vmextension.location change Co-authored-by: sukodava <78733210+sukodava@users.noreply.github.com> Co-authored-by: Dapeng Zhang <dapzhang@microsoft.com> Co-authored-by: xielexie <94083876+xielexie@users.noreply.github.com> Co-authored-by: Mike Richmond <mirichmo@microsoft.com> Co-authored-by: Avinash <akka@usc.edu> Co-authored-by: Avinash Akka <avakka@microsoft.com> Co-authored-by: ms-saypaul <67093296+ms-saypaul@users.noreply.github.com> Co-authored-by: Raktima Das <raktdas@microsoft.com> Co-authored-by: kamusta-msft <56413142+kamusta-msft@users.noreply.github.com> Co-authored-by: frank-pang-msft <92764154+frank-pang-msft@users.noreply.github.com> Co-authored-by: Chase VanBuskirk <chasevanb@gmail.com> Co-authored-by: Chase Van Buskirk <cvanbuskirk@microsoft.com> Co-authored-by: vbhasker-msft <93355049+vbhasker-msft@users.noreply.github.com> Co-authored-by: avjai <34567499+avjai@users.noreply.github.com> Co-authored-by: kangsun-ctrl <69279251+kangsun-ctrl@users.noreply.github.com> Co-authored-by: karthikka4820 <88366202+karthikka4820@users.noreply.github.com> Co-authored-by: LexieXie <lexiexie@microsoft.com> Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>

webpubsub-track2

7727caf

colawwj requested review from deyaaeldeen, dw511214992, mikeharder, praveenkuttappan, qiaozha and witemple-msft as code owners July 27, 2021 08:00

deyaaeldeen reviewed Jul 27, 2021

View reviewed changes

deyaaeldeen approved these changes Jul 27, 2021

View reviewed changes

update

37a4bac

colawwj requested review from danieljurek and weshaggard as code owners August 4, 2021 03:19

qiaozha reviewed Aug 4, 2021

View reviewed changes

eng/ignore-links.txt Show resolved Hide resolved

Update eng/ignore-links.txt

add9d86

qiaozha reviewed Aug 4, 2021

View reviewed changes

sdk/web-pubsub/arm-webpubsub/README.md Outdated Show resolved Hide resolved

qiaozha and others added 3 commits August 4, 2021 14:11

Update sdk/web-pubsub/arm-webpubsub/README.md

f518483

update

282f8e6

update

f3eeebc

qiaozha approved these changes Aug 4, 2021

View reviewed changes

qiaozha merged commit 74419c7 into Azure:main Aug 4, 2021

weshaggard reviewed Aug 4, 2021

View reviewed changes

colawwj deleted the webpubsub branch October 11, 2021 03:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

webpubsub-track2 #16570

webpubsub-track2 #16570

colawwj commented Jul 27, 2021 •

edited

Loading

deyaaeldeen Jul 27, 2021

qiaozha Aug 4, 2021

deyaaeldeen Aug 4, 2021

deyaaeldeen left a comment

weshaggard Aug 4, 2021

qiaozha Aug 5, 2021

weshaggard Aug 4, 2021

qiaozha Aug 5, 2021

weshaggard Aug 5, 2021

weshaggard Aug 4, 2021

qiaozha Aug 5, 2021

weshaggard Aug 5, 2021

		@@ -0,0 +1,14 @@
		## 0.1.0-beta.1 (2021-07-27)

		This is the first preview for the new version of the `@azure/arm-webpubsub` package that follows the new [guidelines for TypeScript SDKs](https://azure.github.io/azure-sdk/typescript_introduction.html) for Azure services.

		@@ -1,5 +1,3 @@
		# NOTE: Please refer to https://aka.ms/azsdk/engsys/ci-yaml before editing this file.

webpubsub-track2 #16570

webpubsub-track2 #16570

Conversation

colawwj commented Jul 27, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

deyaaeldeen left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

colawwj commented Jul 27, 2021 •

edited

Loading