Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Arm cosmosdb release #15789

Merged
merged 3 commits into from
Jun 23, 2021
Merged

Arm cosmosdb release #15789

merged 3 commits into from
Jun 23, 2021

Conversation

colawwj
Copy link
Contributor

@colawwj colawwj commented Jun 17, 2021 •
edited
Loading

@ghost ghost added the Cosmos label Jun 17, 2021
@dw511214992
Copy link
Member

Hi @ramya-rao-a I think the failed pipeline belongs dataplane sdk. Could you look into it? thanks

@ramya-rao-a
Copy link
Contributor

@praveenkuttappan The data plane pipeline should not have been triggered here at all. Can you take a look please?

@dw511214992
Copy link
Member

@ramya-rao-a @praveenkuttappan the data plane pipeline is triggered by the ci.yml in the directory cosmosdb. We can disable trigger the pipeline by changing the ci.yml easily. But I think there may be something wrong with the data plane pipeline, which needs your attention. thanks

@dw511214992
Copy link
Member

Hi @praveenkuttappan Is there any update? I think it has no matter with mgmt plane, and I will merge it later. thanks

@dw511214992
Copy link
Member

/check-enforcer override

@dw511214992 dw511214992 merged commit 63bc1fd into Azure:main Jun 23, 2021
@praveenkuttappan
Copy link
Member

Looking at pipeline triggers, data plane pipline should have been triggered always when anything inside sdk/ folder is changed since trigger is sdk/

Rush runner internally skips arm packages from build and test though.

@colawwj colawwj deleted the arm-cosmosdb-release branch July 16, 2021 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dw511214992 dw511214992 dw511214992 approved these changes

@qiaozha qiaozha Awaiting requested review from qiaozha qiaozha is a code owner

Assignees
No one assigned
Labels
Cosmos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@colawwj @dw511214992 @ramya-rao-a @praveenkuttappan