Normalize the package name for Doc.Ms readme #13453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sima-zhu
requested review from
danieljurek,
mikeharder,
mitchdenny,
praveenkuttappan and
weshaggard
as code owners
weshaggard
reviewed
Jan 28, 2021
eng/scripts/Language-Settings.ps1
Outdated
| @@ -6,30 +6,24 @@ $packagePattern = "*.tgz" | |||
| $MetadataUri = "https://raw.githubusercontent.com/Azure/azure-sdk/master/_data/releases/latest/js-packages.csv" | |||
| $BlobStorageUrl = "https://azuresdkdocs.blob.core.windows.net/%24web?restype=container&comp=list&prefix=javascript%2F&delimiter=%2F" | |||
|
|
|||
| function Get-javascript-PackageInfoFromRepo ($pkgPath, $serviceDirectory, $pkgName) | |||
| { | |||
| function Get-javascript-PackageInfoFromRepo ($pkgPath, $serviceDirectory, $pkgName) { | |||
There was a problem hiding this comment.
Please undo these formatting changes that move the brace.
There was a problem hiding this comment.
My vs code insist helping me format JS code. :(
sima-zhu
force-pushed
the
normalize_package_name
branch
from
add6ff4
to
938d4f4
Compare
weshaggard
reviewed
Jan 29, 2021
eng/scripts/Language-Settings.ps1
Outdated
| # Turn the package name start with `@azure/identity` to "identity". | ||
| function Normalize-javascript-Package-name ($PackageName) | ||
| { | ||
| return $PackageName -replace "@azure/" , "" |
There was a problem hiding this comment.
As I called out in your other PR lets try adding this as another property to the package properties so we don't have yet another small simple function that all languages have to implement.
weshaggard
reviewed
Feb 2, 2021
weshaggard
approved these changes
Feb 2, 2021
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
ghost
pushed a commit
to Azure/azure-sdk-tools
that referenced
this pull request
Feb 2, 2021
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Mar 16, 2021
DPS: fix bad path (Azure#13453)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.