[Cosmos] Fix linting issues #13039
Merged
[Cosmos] Fix linting issues #13039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deyaaeldeen
requested review from
southpolesteve,
xirzec,
willmtemple,
zfoster and
ramya-rao-a
ghost
added
the
zfoster
approved these changes
Jan 5, 2021
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Feb 25, 2021
[Hub Generated] Review request for Microsoft.Consumption to add version stable/2019-10-01 (Azure#13039) * Fix validation errors for UsageDetails_List * fix validations for UsageDetails_List invalid format * update description for meterId Property inLegacyUsageDetailProperties * add examples for 503 response for Microsoft.Consumption usage details * fix spelling for productIdentifier description * fix spell check in productIdentifier description in ModernUsageDetailProperties * reverting bad fixes for swagger validations * remove 503 as a separate status * fix typos and add uuid back (will be fixed in code) Co-authored-by: Mohammad Mohammad <mmohammad@microsoft.com>
ramya-rao-a
requested review from
zfoster
and removed request for
willmtemple
|
this seems to have an actual compilation failure now with the hashing "v2Key" not assignable to boolean |
This was referenced Feb 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes linting issues in
src,samples,package.json, andapi-extractor.json. Fixes #10776.Things to note
@azure/azure-sdk/ts-naming-optionsand@azure/azure-sdk/ts-apisurface-supportcancellationrequire breaking changes, so I changed their reporting mode towarnfor now.tsdoc/syntaxrule requires the documentation to conform to TSDoc standard. I changed its reporting mode towarnfor now. There is already an issue opened for this: [Cosmos] Migrate documentation comments to TSDoc #12951.@azure/azure-sdk/ts-doc-internalis looking for the JSDoc tag@ignorewhich is no longer a supported behavior. I fixed this here: [ESLint Plugin] ts-doc-internal checks for hidden instead of ignore #13038 and changed its reporting mode towarnfor now. Once [ESLint Plugin] ts-doc-internal checks for hidden instead of ignore #13038 is merged, we will need to revert that change back.@azure/azure-sdk/ts-package-json-modulerequires changes to the typescript settings. I think it is better addressed by the cosmos team and I changed its reporting mode towarn.anyin argument position. My approach to fix this is to try and figure out a concrete type for that argument and I was able to do that in a few places. When I could not, I replacedanywithunknown.ban-typesprohibits using types such asobjectand{}. I tried my best to address those, mostly by replacing them usingRecord<string, unknown>(the type of any object), andunknown. Feel free to suggest better alternatives in those cases.sdk/cosmosdb/cosmos/src/request/StatusCodes.tshas a type for status codes computed from constants. However, TypeScript reduces that type tonumber. So for readability, I defined that type to benumber.After rebasing changes
import/no-extraneous-dependenciesbecause it currently fails with this issue: v2.21 recursion error atimportstatement import-js/eslint-plugin-import#1816.dev-tool's standard rollup config.checkURLmethod into its own module so that if in the future another part needs to importURL, they can do so without importingcheckURL. Also got rid of therequirecall there because AFAIKnode v8.17has aurlmodule and this should be the version to support at this point. Text Analytics does the same here: https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/textanalytics/ai-text-analytics/src/utils/url.ts.isomorphic-webcrypto.