Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove @param and @returns tags if they have no description #12943

Merged
2 commits merged into from
Dec 17, 2020
Merged

Remove @param and @returns tags if they have no description #12943

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb67dad
address feedback
deyaaeldeen Dec 17, 2020
87d7da8
address feedback
deyaaeldeen Dec 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions sdk/core/core-http/src/credentials/accessTokenRefresher.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@ export class AccessTokenRefresher {
/**
* Returns true if the required milliseconds(defaulted to 30000) have been passed signifying
* that we are ready for a new refresh.
*
* @returns
*/
public isReady(): boolean {
// We're only ready for a new refresh if the required milliseconds have passed.
Expand All @@ -34,7 +32,6 @@ export class AccessTokenRefresher {
* then requests a new token,
* then sets this.promise to undefined,
* then returns the token.
* @param options -
deyaaeldeen marked this conversation as resolved.
Show resolved Hide resolved
*/
private async getToken(options: GetTokenOptions): Promise<AccessToken | undefined> {
this.lastCalled = Date.now();
Expand Down
10 changes: 5 additions & 5 deletions sdk/core/core-http/test/data/TestClient/src/testClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,16 @@
import * as msRest from "../../../../src/coreHttp";
import { Mappers } from "./models/mappers";

/**
* @param baseUri - The base URI of the service.
* @param options - The parameter options
*/

class TestClient extends msRest.ServiceClient {
baseUri?: string;
acceptLanguage?: string;
models?: any;
serializer: msRest.Serializer;

/**
* @param baseUri - The base URI of the service.
* @param options - The parameter options
*/
constructor(baseUri: string, options?: msRest.ServiceClientOptions) {
if (!options) options = {};
super(undefined, options);
Expand Down
1 change: 1 addition & 0 deletions sdk/formrecognizer/ai-form-recognizer/src/formRecognizerClient.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,7 @@ export class FormRecognizerClient {

/**
* @internal
* @hidden
* A reference to the auto-generated FormRecognizer HTTP client.
*/
private readonly client: GeneratedClient;
Expand Down
1 change: 0 additions & 1 deletion sdk/tables/data-tables/src/TableBatch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,6 @@ function parseBatchResponse(batchResponse: HttpOperationResponse): TableBatchRes
/**
* Prepares the operation url to be added to the body, removing the SAS token if present
* @param url - Source URL string
* @returns
deyaaeldeen marked this conversation as resolved.
Show resolved Hide resolved
*/
function getSubRequestUrl(url: string): string {
const sasTokenParts = ["sv", "ss", "srt", "sp", "se", "st", "spr", "sig"];
Expand Down