Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tables] Setup Storage CORS in post-deployment script #11612

Merged
merged 5 commits into from
Oct 2, 2020
Merged

[Tables] Setup Storage CORS in post-deployment script #11612

merged 5 commits into from
Oct 2, 2020

Conversation

joheredi
Copy link
Member

@joheredi joheredi commented Oct 2, 2020

  • Script that adds CORS configuration for test resources
  • Remove disable-security flag in karma
  • Cleanup test-resources.json

@ghost ghost added the Tables label Oct 2, 2020
@joheredi
Copy link
Member Author

joheredi commented Oct 2, 2020

/azp run js - tables - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

)

$storageAccountName = $DeploymentOutputs['ACCOUNT_NAME']
$context = New-AzStorageContext -StorageAccountName $storageAccountName
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you try to pass ACCOUNT_KEY also to context like in following command.

$storageContext = New-AzStorageContext -StorageAccountName $storageAccount -StorageAccountKey $DeploymentOutputs['ACCOUNT_KEY']

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! it worked 😄

@joheredi
Copy link
Member Author

joheredi commented Oct 2, 2020

/azp run js - tables - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@joheredi
Copy link
Member Author

joheredi commented Oct 2, 2020

/azp run js - tables - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@joheredi
Copy link
Member Author

joheredi commented Oct 2, 2020

/azp run js - tables - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@joheredi joheredi requested a review from ellismg October 2, 2020 17:22
@joheredi joheredi changed the title [Tables] Add post ps1 script [Tables] Setup Storage CORS in post script Oct 2, 2020
@joheredi joheredi changed the title [Tables] Setup Storage CORS in post script [Tables] Setup Storage CORS in post-deployment script Oct 2, 2020
Copy link
Member

@ellismg ellismg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joheredi joheredi merged commit d6ce59e into Azure:master Oct 2, 2020
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Nov 12, 2020
Revert: spec changes for Libmary Management in bigDataPool (Azure#11612)

* Revert "attributes added in LibraryInfo in BigDataPool specs (Azure#11415)"

This reverts commit 5d48a7dc324dd221d5e0455e3947c5fc39084132.

* Revert "Custom Library support in Spark pool (Azure#11172)"

This reverts commit c653ee788c4dd74ede34ff17e64e7c0c45681e3e.

Co-authored-by: Navneet Singh <navsi@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants