Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update @opentelemetry/api to latest version #10393

Merged
merged 4 commits into from
Aug 4, 2020
Merged

Update @opentelemetry/api to latest version #10393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
089ca42
Update @opentelemetry/api to latest version
ramya-rao-a Aug 1, 2020
cc85591
Update to 0.10.2
ramya-rao-a Aug 4, 2020
6fc48a5
span.kind need not be cast to string
ramya-rao-a Aug 4, 2020
c56b4ad
Remove exception for monitor
ramya-rao-a Aug 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions common/config/rush/common-versions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,6 @@

// Monitor: Allow node 10 types until Timeout / Timer conflict is resolved in OpenTelemetry repo
// TODO: remove when released https://github.com/open-telemetry/opentelemetry-js/pull/1352
"@types/node": ["^10.0.0"],

// Monitor: Always test on latest version of OpenTelemetry
"@opentelemetry/api": ["^0.10.1"]
"@types/node": ["^10.0.0"]
}
}
122 changes: 68 additions & 54 deletions common/config/rush/pnpm-lock.yaml
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions sdk/appconfiguration/app-configuration/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,8 @@
"@azure/core-asynciterator-polyfill": "^1.0.0",
"@azure/core-http": "^1.1.4",
"@azure/core-paging": "^1.1.1",
"@azure/core-tracing": "1.0.0-preview.8",
"@opentelemetry/api": "^0.6.1",
"@azure/core-tracing": "1.0.0-preview.9",
"@opentelemetry/api": "^0.10.2",
"tslib": "^2.0.0"
},
"devDependencies": {
Expand Down
4 changes: 2 additions & 2 deletions sdk/core/core-auth/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,8 @@
"sideEffects": false,
"dependencies": {
"@azure/abort-controller": "^1.0.0",
"@azure/core-tracing": "1.0.0-preview.8",
"@opentelemetry/api": "^0.6.1",
"@azure/core-tracing": "1.0.0-preview.9",
"@opentelemetry/api": "^0.10.2",
"tslib": "^2.0.0"
},
"devDependencies": {
Expand Down
4 changes: 2 additions & 2 deletions sdk/core/core-client/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,8 @@
"@azure/abort-controller": "^1.0.0",
"@azure/core-auth": "^1.1.3",
"@azure/core-https": "1.0.0-preview.1",
"@azure/core-tracing": "1.0.0-preview.8",
"@opentelemetry/api": "^0.6.1",
"@azure/core-tracing": "1.0.0-preview.9",
"@opentelemetry/api": "^0.10.2",
"tslib": "^2.0.0"
},
"devDependencies": {
Expand Down
4 changes: 2 additions & 2 deletions sdk/core/core-http/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,9 +129,9 @@
"dependencies": {
"@azure/abort-controller": "^1.0.0",
"@azure/core-auth": "^1.1.3",
"@azure/core-tracing": "1.0.0-preview.8",
"@azure/core-tracing": "1.0.0-preview.9",
"@azure/logger": "^1.0.0",
"@opentelemetry/api": "^0.6.1",
"@opentelemetry/api": "^0.10.2",
"@types/node-fetch": "^2.5.0",
"@types/tunnel": "^0.0.1",
"form-data": "^3.0.0",
Expand Down
4 changes: 2 additions & 2 deletions sdk/core/core-https/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,9 +91,9 @@
"dependencies": {
"@azure/abort-controller": "^1.0.0",
"@azure/core-auth": "^1.1.3",
"@azure/core-tracing": "1.0.0-preview.8",
"@azure/core-tracing": "1.0.0-preview.9",
"@azure/logger": "^1.0.0",
"@opentelemetry/api": "^0.6.1",
"@opentelemetry/api": "^0.10.2",
"form-data": "^3.0.0",
"tslib": "^2.0.0",
"https-proxy-agent": "^5.0.0",
Expand Down
2 changes: 1 addition & 1 deletion sdk/core/core-lro/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@
"tslib": "^2.0.0"
},
"devDependencies": {
"@opentelemetry/api": "^0.6.1",
"@opentelemetry/api": "^0.10.2",
"@microsoft/api-extractor": "7.7.11",
"@rollup/plugin-commonjs": "11.0.2",
"@rollup/plugin-multi-entry": "^3.0.0",
Expand Down
2 changes: 1 addition & 1 deletion sdk/core/core-tracing/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@
"sideEffects": false,
"dependencies": {
"@opencensus/web-types": "0.0.7",
"@opentelemetry/api": "^0.6.1",
"@opentelemetry/api": "^0.10.2",
"tslib": "^2.0.0"
},
"devDependencies": {
Expand Down
4 changes: 2 additions & 2 deletions sdk/eventhub/event-hubs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,9 +83,9 @@
"@azure/abort-controller": "^1.0.0",
"@azure/core-amqp": "^1.1.4",
"@azure/core-asynciterator-polyfill": "^1.0.0",
"@azure/core-tracing": "1.0.0-preview.8",
"@azure/core-tracing": "1.0.0-preview.9",
"@azure/logger": "^1.0.0",
"@opentelemetry/api": "^0.6.1",
"@opentelemetry/api": "^0.10.2",
"buffer": "^5.2.1",
"process": "^0.11.10",
"rhea-promise": "^1.0.0",
Expand Down
4 changes: 2 additions & 2 deletions sdk/formrecognizer/ai-form-recognizer/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,9 @@
"@azure/core-lro": "^1.0.2",
"@azure/core-paging": "^1.1.1",
"@azure/core-http": "^1.1.4",
"@azure/core-tracing": "1.0.0-preview.8",
"@azure/core-tracing": "1.0.0-preview.9",
"@azure/logger": "^1.0.0",
"@opentelemetry/api": "^0.6.1",
"@opentelemetry/api": "^0.10.2",
"tslib": "^2.0.0"
},
"devDependencies": {
Expand Down
4 changes: 2 additions & 2 deletions sdk/identity/identity/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,9 +82,9 @@
"sideEffects": false,
"dependencies": {
"@azure/core-http": "^1.1.4",
"@azure/core-tracing": "1.0.0-preview.8",
"@azure/core-tracing": "1.0.0-preview.9",
"@azure/logger": "^1.0.0",
"@opentelemetry/api": "^0.6.1",
"@opentelemetry/api": "^0.10.2",
"events": "^3.0.0",
"jws": "^4.0.0",
"msal": "^1.0.2",
Expand Down
4 changes: 2 additions & 2 deletions sdk/keyvault/keyvault-admin/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,8 @@
"sideEffects": false,
"dependencies": {
"@azure/core-http": "^1.1.4",
"@azure/core-tracing": "1.0.0-preview.8",
"@opentelemetry/api": "^0.6.1",
"@azure/core-tracing": "1.0.0-preview.9",
"@opentelemetry/api": "^0.10.2",
"tslib": "^2.0.0"
},
"devDependencies": {
Expand Down
4 changes: 2 additions & 2 deletions sdk/keyvault/keyvault-certificates/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,9 @@
"@azure/core-http": "^1.1.4",
"@azure/core-lro": "^1.0.2",
"@azure/core-paging": "^1.1.1",
"@azure/core-tracing": "1.0.0-preview.8",
"@azure/core-tracing": "1.0.0-preview.9",
"@azure/logger": "^1.0.0",
"@opentelemetry/api": "^0.6.1",
"@opentelemetry/api": "^0.10.2",
"tslib": "^2.0.0"
},
"devDependencies": {
Expand Down
4 changes: 2 additions & 2 deletions sdk/keyvault/keyvault-keys/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,9 +86,9 @@
"@azure/core-http": "^1.1.4",
"@azure/core-lro": "^1.0.2",
"@azure/core-paging": "^1.1.1",
"@azure/core-tracing": "1.0.0-preview.8",
"@azure/core-tracing": "1.0.0-preview.9",
"@azure/logger": "^1.0.0",
"@opentelemetry/api": "^0.6.1",
"@opentelemetry/api": "^0.10.2",
"tslib": "^2.0.0"
},
"devDependencies": {
Expand Down
4 changes: 2 additions & 2 deletions sdk/keyvault/keyvault-secrets/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,9 +90,9 @@
"@azure/core-http": "^1.1.4",
"@azure/core-lro": "^1.0.2",
"@azure/core-paging": "^1.1.1",
"@azure/core-tracing": "1.0.0-preview.8",
"@azure/core-tracing": "1.0.0-preview.9",
"@azure/logger": "^1.0.0",
"@opentelemetry/api": "^0.6.1",
"@opentelemetry/api": "^0.10.2",
"tslib": "^2.0.0"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion sdk/monitor/opentelemetry-exporter/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
"typescript": "~3.9.3"
},
"dependencies": {
"@opentelemetry/api": "^0.10.1",
"@opentelemetry/api": "^0.10.2",
"@opentelemetry/core": "^0.10.1",
"@opentelemetry/semantic-conventions": "^0.10.1",
"@opentelemetry/tracing": "^0.10.1"
Expand Down
4 changes: 2 additions & 2 deletions sdk/monitor/opentelemetry-exporter/src/utils/spanUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,9 +210,9 @@ export function readableSpanToEnvelope(
default:
// never
if (logger) {
logger.error(`Unsupported span kind ${span.kind as string}`);
logger.error(`Unsupported span kind ${span.kind}`);
}
throw new Error(`Unsupported span kind ${span.kind as string}`);
throw new Error(`Unsupported span kind ${span.kind}`);
}

envelope.data.baseData = { ...data, properties };
Expand Down
4 changes: 2 additions & 2 deletions sdk/search/search-documents/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,9 @@
"@azure/core-auth": "^1.1.3",
"@azure/core-http": "^1.1.4",
"@azure/core-paging": "^1.1.1",
"@azure/core-tracing": "1.0.0-preview.8",
"@azure/core-tracing": "1.0.0-preview.9",
"@azure/logger": "^1.0.0",
"@opentelemetry/api": "^0.6.1",
"@opentelemetry/api": "^0.10.2",
"tslib": "^2.0.0"
},
"devDependencies": {
Expand Down
4 changes: 2 additions & 2 deletions sdk/servicebus/service-bus/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,9 +90,9 @@
"@azure/core-amqp": "^1.1.4",
"@azure/core-asynciterator-polyfill": "^1.0.0",
"@azure/core-http": "^1.1.4",
"@azure/core-tracing": "1.0.0-preview.8",
"@azure/core-tracing": "1.0.0-preview.9",
"@azure/core-paging": "^1.1.1",
"@opentelemetry/api": "^0.6.1",
"@opentelemetry/api": "^0.10.2",
"@types/is-buffer": "^2.0.0",
"@types/long": "^4.0.0",
"buffer": "^5.2.1",
Expand Down
4 changes: 2 additions & 2 deletions sdk/storage/storage-blob-changefeed/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,9 +101,9 @@
"@azure/core-http": "^1.1.4",
"@azure/core-lro": "^1.0.2",
"@azure/core-paging": "^1.1.1",
"@azure/core-tracing": "1.0.0-preview.8",
"@azure/core-tracing": "1.0.0-preview.9",
"@azure/logger": "^1.0.0",
"@opentelemetry/api": "^0.6.1",
"@opentelemetry/api": "^0.10.2",
"events": "^3.0.0",
"tslib": "^2.0.0"
},
Expand Down
4 changes: 2 additions & 2 deletions sdk/storage/storage-blob/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,9 +102,9 @@
"@azure/core-http": "^1.1.4",
"@azure/core-lro": "^1.0.2",
"@azure/core-paging": "^1.1.1",
"@azure/core-tracing": "1.0.0-preview.8",
"@azure/core-tracing": "1.0.0-preview.9",
"@azure/logger": "^1.0.0",
"@opentelemetry/api": "^0.6.1",
"@opentelemetry/api": "^0.10.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides "change compile target to es5", is there any other changes involved and could influence end user?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks this is the only change that affects us
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeremymeng: You want to look at all breaking changes between 0.6.1 and 0.10.2, not just the changes in the 0.10.2 release. I personally do not know if or how any of these breaking changes might impact our packages.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fortunately we use very little of their public surface area and active development has been in other areas

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh that's right I was only looking at last release. But Jeff knows more!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through all the release notes from 0.6.1 -- there were breaking changes in metrics (which we don't use yet), but not tracing.

"events": "^3.0.0",
"tslib": "^2.0.0"
},
Expand Down
4 changes: 2 additions & 2 deletions sdk/storage/storage-file-datalake/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@
"@azure/abort-controller": "^1.0.0",
"@azure/core-http": "^1.1.4",
"@azure/core-paging": "^1.1.1",
"@azure/core-tracing": "1.0.0-preview.8",
"@azure/core-tracing": "1.0.0-preview.9",
"@azure/logger": "^1.0.0",
"@azure/storage-blob": "^12.2.0-preview.1",
"events": "^3.0.0",
Expand All @@ -107,7 +107,7 @@
"@azure/identity": "^1.1.0-preview",
"@azure/test-utils-recorder": "^1.0.0",
"@microsoft/api-extractor": "7.7.11",
"@opentelemetry/api": "^0.6.1",
"@opentelemetry/api": "^0.10.2",
"@rollup/plugin-commonjs": "11.0.2",
"@rollup/plugin-multi-entry": "^3.0.0",
"@rollup/plugin-node-resolve": "^8.0.0",
Expand Down
4 changes: 2 additions & 2 deletions sdk/storage/storage-file-share/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,9 +102,9 @@
"@azure/abort-controller": "^1.0.0",
"@azure/core-http": "^1.1.4",
"@azure/core-paging": "^1.1.1",
"@azure/core-tracing": "1.0.0-preview.8",
"@azure/core-tracing": "1.0.0-preview.9",
"@azure/logger": "^1.0.0",
"@opentelemetry/api": "^0.6.1",
"@opentelemetry/api": "^0.10.2",
"events": "^3.0.0",
"tslib": "^2.0.0"
},
Expand Down
4 changes: 2 additions & 2 deletions sdk/storage/storage-queue/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,9 +99,9 @@
"@azure/abort-controller": "^1.0.0",
"@azure/core-http": "^1.1.4",
"@azure/core-paging": "^1.1.1",
"@azure/core-tracing": "1.0.0-preview.8",
"@azure/core-tracing": "1.0.0-preview.9",
"@azure/logger": "^1.0.0",
"@opentelemetry/api": "^0.6.1",
"@opentelemetry/api": "^0.10.2",
"tslib": "^2.0.0"
},
"devDependencies": {
Expand Down
4 changes: 2 additions & 2 deletions sdk/tables/azure-tables/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
"private": true,
"dependencies": {
"@azure/core-http": "^1.1.4",
"@opentelemetry/api": "^0.6.1",
"@opentelemetry/api": "^0.10.2",
"tslib": "^2.0.0"
},
"devDependencies": {
Expand Down Expand Up @@ -122,4 +122,4 @@
"typescript": "~3.9.3",
"util": "^0.12.1"
}
}
}
4 changes: 2 additions & 2 deletions sdk/template/template/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,9 @@
"dependencies": {
"@azure/core-auth": "^1.1.3",
"@azure/core-http": "^1.1.4",
"@azure/core-tracing": "1.0.0-preview.8",
"@azure/core-tracing": "1.0.0-preview.9",
"@azure/logger": "^1.0.0",
"@opentelemetry/api": "^0.6.1",
"@opentelemetry/api": "^0.10.2",
"events": "^3.0.0",
"tslib": "^2.0.0"
},
Expand Down
2 changes: 1 addition & 1 deletion sdk/test-utils/perfstress/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
"dependencies": {
"@azure/abort-controller": "^1.0.0",
"@azure/core-http": "^1.1.4",
"@opentelemetry/api": "^0.6.1",
"@opentelemetry/api": "^0.10.2",
"tslib": "^2.0.0",
"node-fetch": "^2.6.0",
"minimist": "~1.2.5",
Expand Down
2 changes: 1 addition & 1 deletion sdk/test-utils/recorder/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
"private": true,
"dependencies": {
"@azure/core-http": "^1.1.4",
"@opentelemetry/api": "^0.6.1",
"@opentelemetry/api": "^0.10.2",
"fs-extra": "^8.1.0",
"nise": "^4.0.3",
"nock": "^12.0.3",
Expand Down
8 changes: 5 additions & 3 deletions sdk/textanalytics/ai-text-analytics/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,9 @@
}
]
},
"engines" : { "node" : ">=8.0.0" },
"engines": {
"node": ">=8.0.0"
},
"scripts": {
"audit": "node ../../../common/scripts/rush-audit.js && rimraf node_modules package-lock.json && npm i --package-lock-only 2>&1 && npm audit",
"build:browser": "tsc -p . && cross-env ONLY_BROWSER=true rollup -c 2>&1",
Expand Down Expand Up @@ -72,9 +74,9 @@
"dependencies": {
"@azure/core-auth": "^1.1.3",
"@azure/core-http": "^1.1.4",
"@azure/core-tracing": "1.0.0-preview.8",
"@azure/core-tracing": "1.0.0-preview.9",
"@azure/logger": "^1.0.0",
"@opentelemetry/api": "^0.6.1",
"@opentelemetry/api": "^0.10.2",
"tslib": "^2.0.0"
},
"devDependencies": {
Expand Down