[Identity] Make keytar an optional dependency #10142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
joshfree
added
blocking-release
joshfree
approved these changes
Jul 20, 2020
schaabs
approved these changes
Jul 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As keytar does not build on all platforms where we support Azure Identity, make keytar an optional dependency. If keytar is not available, fail gracefully with a message telling the user why the VSCode credential could not be used.
Helps to address #9288 and related issues, where the given platform may not have the ability to install the dependencies keytar needs (and therefore keytar fails to build), or on a platform where keytar itself isn't support (eg on Linux running without X11/Xorg).