Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Storage][Blob] Adjust BlockBlobClient.uploadStream parameter: provide default value for bufferSize and maxBuffers; rename maxBuffers to maxConcurrency #5456

Closed
jeremymeng opened this issue Oct 8, 2019 · 1 comment · Fixed by #5740
Closed

[Storage][Blob] Adjust BlockBlobClient.uploadStream parameter: provide default value for bufferSize and maxBuffers; rename maxBuffers to maxConcurrency #5456

jeremymeng opened this issue Oct 8, 2019 · 1 comment · Fixed by #5740
Assignees
@joheredi
Labels
Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)

Comments

@jeremymeng
Copy link
Member

jeremymeng commented Oct 8, 2019 •
edited
Loading

bufferSize of 8MB and maxConcurrency of 5
@jeremymeng jeremymeng added Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files) labels Oct 8, 2019
@triage-new-issues triage-new-issues bot removed the triage label Oct 8, 2019
@jeremymeng jeremymeng added the blocking-release Blocks release label Oct 10, 2019
@ramya-rao-a ramya-rao-a self-assigned this Oct 17, 2019
@ramya-rao-a ramya-rao-a removed the blocking-release Blocks release label Oct 17, 2019
@ramya-rao-a
Copy link
Contributor

@bterlson, @HarshaNalluru, @jeremymeng ,

Since renaming a method argument and providing defaults are not breaking api changes, am removing the "blocking-release" label on this issue

@joheredi joheredi mentioned this issue Oct 23, 2019
Merged
azure-sdk pushed a commit that referenced this issue Feb 21, 2023
@mikeharder @azure-sdk
Add vmImage back to common perf.yml - Fixes #5466 - Partially reverts #…
93a064a 
…5456
azure-sdk pushed a commit that referenced this issue Feb 21, 2023
@mikeharder @azure-sdk
Add vmImage back to common perf.yml - Fixes #5466 - Partially reverts #…
cdc5f46 
…5456
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joheredi joheredi

Labels
Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Storage][Blob] Default values for uploadStream parameters
3 participants
@jeremymeng @ramya-rao-a @joheredi