Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JS] [Service Bus] Fix missing TypeScript definitions for https-proxy-agent #3064

Closed
sadasant opened this issue May 21, 2019 · 2 comments
Closed

[JS] [Service Bus] Fix missing TypeScript definitions for https-proxy-agent #3064

sadasant opened this issue May 21, 2019 · 2 comments
Assignees
@HarshaNalluru
Labels
Client This issue points to a problem in the data-plane of the library. Service Bus
Milestone
[2020] June

Comments

@sadasant
Copy link
Contributor

sadasant commented May 21, 2019 •
edited
Loading

In Service Bus' TypeScript samples we are importing https-proxy-agent, however: There are no TypeScript definitions for this package. This issue even exists in the source repository for this module, see: TooTallNate/proxy-agents#27

As @ramya-rao-a suggested offline:

Contributing the typings upstream is the right step forward.

Let's get in touch with @TooTallNate and then let's send him a PR with the missing definitions ✨

Note: I have assigned this to me, but feel free to assign it to someone else.
@sadasant sadasant added Client This issue points to a problem in the data-plane of the library. Service Bus labels May 21, 2019
@sadasant sadasant self-assigned this May 21, 2019
@sadasant
Copy link
Contributor Author

sadasant commented May 21, 2019 •
edited
Loading

Update:
The one and only @TooTallNate merged a PR that I made addressing this TooTallNate/proxy-agents#66

We still need to wait for the version bump.

sadasant added a commit that referenced this issue May 21, 2019
@sadasant
Small changes after type definitions are added
ed7bef0 
Once https-proxy-agent type definitions are added,
these changes will be necessary to make this sample work.

The PR that introduces the TypeScript definitions to https-proxy-agent
is:
TooTallNate/proxy-agents#66

This commit is related to
#3064
@sadasant sadasant mentioned this issue May 21, 2019
Closed
sadasant added a commit to sadasant/azure-sdk-for-js that referenced this issue Jul 6, 2019
@sadasant
[ServiceBus] [EventHubs] Updated https-proxy-agent
e6c9085 
Version 2.2.2 was released with some TypeScript definitions! Time to
update.

Fixes Azure#3064
@sadasant sadasant mentioned this issue Jul 6, 2019
Closed
@ramya-rao-a ramya-rao-a added this to the [2020] June milestone Apr 10, 2020
@HarshaNalluru
Copy link
Member

Closing this since we have the types now :)

@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@HarshaNalluru HarshaNalluru

Labels
Client This issue points to a problem in the data-plane of the library. Service Bus
Projects
None yet
Milestone
[2020] June
3 participants
@sadasant @HarshaNalluru @ramya-rao-a