Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Unified Recorder] Allow passing "undefined" keys to the sanitizers #19559

Closed
2 tasks
HarshaNalluru opened this issue Dec 27, 2021 · 0 comments · Fixed by #19561
Closed
2 tasks

[Unified Recorder] Allow passing "undefined" keys to the sanitizers #19559

HarshaNalluru opened this issue Dec 27, 2021 · 0 comments · Fixed by #19561
Assignees
@HarshaNalluru
Labels
test-utils-recorder Label for the issues related to the common recorder
Milestone
[2022] January

Comments

@HarshaNalluru
Copy link
Member

HarshaNalluru commented Dec 27, 2021 •
edited
Loading

  • Allow passing undefined to the sanitizers so that devs don't have to add additional checks if the env.CONNECTION_STRING exists in different test modes while being passed to the sanitizers.
  • Instead, add internal checks to make sure "undefined" sanitizers are not added to the session
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 27, 2021
@HarshaNalluru HarshaNalluru self-assigned this Dec 27, 2021
@HarshaNalluru HarshaNalluru added the test-utils-recorder Label for the issues related to the common recorder label Dec 27, 2021
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 27, 2021
@HarshaNalluru HarshaNalluru added this to the [2022] January milestone Dec 27, 2021
This was referenced Dec 27, 2021
Closed
Merged
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-js that referenced this issue Jul 20, 2022
@serbrech @lht6 @haitch
CodeGen from PR 19653 in Azure/azure-rest-api-specs
7ce41a2 
Review request for Microsoft.ContainerService to add version 2022-06-02-preview (Azure#19653)

* Adds base for updating Microsoft.ContainerService from version preview/2022-05-02-preview to version 2022-06-02-preview

* Updates readme

* Updates API version in new specs and examples

* update readmes (Azure#19422)

* Containerservice 2022 06 02 preview fleet (Azure#19541)

* add fleets and fleet members resource types

* remove clusterLocation

* wording

* don't flatten  hubprofile

* extra comma

* fix patch example

* Fix violated rule R4041 for 2022-06-02-preview managedCluster swagger (Azure#19582)

* remove useless directive

* fix R4041

* fix

* add node restriction to swagger (Azure#19587)

* aks fleet list credentials api (Azure#19559)

* add fleet list credential api

* tweaks

* fix example filename

* fix casing

* add resourceId on hubProfile

* drop the new field, keep it as internal field

* fix duplicate shema error

* different name for fleet credential results

* use xms-identifier on the array items

* prettier fi

Co-authored-by: Stephane Erbrech <stephane.erbrech@gmail.com>

* sterbrec - address fleet comments - Microsoft.ContainerService - 2022-06-02-preview (Azure#19783)

* address fleet comments

* add example for nadditional status code

* Add missing `x-ms-long-running-operation-options` for delete operations in fleet-related API (Azure#19787)

* add final-state-via

* fix final state to location header

Co-authored-by: Stéphane Erbrech <stephane.erbrech@gmail.com>
Co-authored-by: lht6 <46062996+lht6@users.noreply.github.com>
Co-authored-by: Haitao Chen <haitch@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@HarshaNalluru HarshaNalluru

Labels
test-utils-recorder Label for the issues related to the common recorder
Projects
None yet
Milestone
[2022] January
1 participant
@HarshaNalluru