Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eventhub] Failing build:samples scripts #12731

Closed
willmtemple opened this issue Dec 1, 2020 · 2 comments
Closed

[eventhub] Failing build:samples scripts #12731

willmtemple opened this issue Dec 1, 2020 · 2 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs
Milestone

Comments

@willmtemple
Copy link
Contributor

Sample Quality Effort

This issue was created because one or more packages in the eventhub service directory had failing build:samples NPM scripts, and I determined that the existing script was broken and could not work, or would take extra effort to repair. #12715 (Build Samples in PR CI) will replace the broken script with a placeholder that simply executes echo Skipped..

The packages in question are:

  • @azure/eventhubs-checkpointstore-blob
  • @azure/event-processor-host

Usually, these errors were caused by faulty assumptions, such as:

  • a script that executes cd samples && tsc -p ., but with no tsconfig.json or other required files in the samples folder
  • use of old samples scripts that no longer exist
  • use of new samples scripts (dev-tool) without a correct samples folder layout (e.g. missing typescript subfolder)

What do I do about this?

  1. If the package is not customer-facing, and there are not intended to be any samples in the package (such as internal code-sharing packages): leave a comment and close this issue.
  2. If there are currently no samples, but the package is customer facing and you intend to add samples eventually: create a tracking issue for samples if one does not exist already and close this issue.
  3. If there are samples, and they should build, but the current scripts are not correct, either:
    a. Create an issue to fix the errors and wait until Add PR CI step to build samples #12715 is merged, then incorporate your changes.
    b. Work with me to incorporate the necessary changes into Add PR CI step to build samples #12715.
  4. If you believe this is an error, that the package is correctly configured, and that the script should work: leave a review with a request for changes on Add PR CI step to build samples #12715 describing how to run the samples, so that we can reconcile the build scripts with the packages' sample programs.
@willmtemple willmtemple added Client This issue points to a problem in the data-plane of the library. Event Hubs labels Dec 1, 2020
@willmtemple willmtemple added this to the MQ-2020 milestone Dec 1, 2020
@chradek
Copy link
Contributor

chradek commented Dec 3, 2020

@azure/event-processor-host fixed by willmtemple#4
@azure/eventhubs-checkpointstore-blob fixed by willmtemple#3

Both should be fixed in master as part of #12715

@willmtemple
Copy link
Contributor Author

Both PRs were merged into the larger PR #12715

openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Feb 4, 2021
Resource mover new api version 2021-01-01 (Azure#12731)

* Added new 2021-01-01 Api version for Azure Resource Mover.

* Changes for new API version.

* Added new Swagger API version for resource mover.

Co-authored-by: Ajay Gupta <ajgupt@microsoft.com>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs
Projects
None yet
Development

No branches or pull requests

2 participants