Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement an Event Hubs Shared Access Key Credential #11892

Closed
jsquire opened this issue Oct 16, 2020 · 1 comment
Closed

Implement an Event Hubs Shared Access Key Credential #11892

jsquire opened this issue Oct 16, 2020 · 1 comment
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs

Comments

@jsquire
Copy link
Member

jsquire commented Oct 16, 2020

Summary

Event Hubs allows for authorization using a shared key and shared access signature that is currently only supported when using a connection string. To align with best practices, we would like to guide library users to down the path of using Identity credentials for production applications. In order to provide a unified approach to authorization around the use of a credential for all scenarios, a service-specific credential type that mimics the API of the TokenCredential is desirable.

Scope of Work

  • Design and implementation of a EventHubsSharedAccessKeyCredential type where the API mimics the TokenCredential form.

  • The credential should NOT derive from TokenCredential to avoid accidentally attempting to use it with another service.

  • The credential should support creation using a shared key name and shared key value combination.

  • The credential should support creation using a shared access signature.

  • The credential should allow the shared key and value or the shared access signature to be updated without stopping or recreating the associated clients.

  • The proposed surface area of the credential, as well as changes to the client API to accept it should be reviewed with the language architect, and approval obtained. Full board review is not necessary.

Success Criteria

  • The design of a credential type detailed by the scope has been completed and approved by the language architect.

  • The credential has been implemented according to the design and is exposed as part of the public API of the library.

  • All clients that accept a TokenCredential also accept the new EventHubsSharedAccessKeyCredential in a similar manner,

  • The tests necessary for its validation have been created or adjusted and pass reliably.

  • The existing test suite continues to produce deterministic results and pass reliably.

References

@jsquire jsquire added Client This issue points to a problem in the data-plane of the library. Event Hubs needs-team-triage Workflow: This issue needs the team to triage. labels Oct 16, 2020
@ramya-rao-a ramya-rao-a added this to the [2020] November milestone Oct 19, 2020
@ramya-rao-a ramya-rao-a removed the needs-team-triage Workflow: This issue needs the team to triage. label Oct 19, 2020
@ramya-rao-a ramya-rao-a modified the milestones: [2020] November, Backlog Oct 22, 2020
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Dec 23, 2020
@ramya-rao-a ramya-rao-a added Epic and removed Epic labels Feb 24, 2021
@chradek
Copy link
Contributor

chradek commented Jul 21, 2021

Shared Access Key and Shared Access Signature credential support was added to event hubs as part of #14423 and included in version 5.5.0 of the @azure/event-hubs package.

@chradek chradek closed this as completed Jul 21, 2021
@xirzec xirzec removed this from the Backlog milestone May 17, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs
Projects
None yet
Development

No branches or pull requests

4 participants