Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new json config for smoke test configuration at package level #11405

Closed
praveenkuttappan opened this issue Sep 22, 2020 · 6 comments
Closed
Assignees
Labels
Central-EngSys This issue is owned by the Engineering System team.

Comments

@praveenkuttappan
Copy link
Member

Currently smoke test configuration like whether package or any specific sample file is opted out is configured in main package.json in package root. This actually adds more details in package.json which already has lot of. configuration details. Smoke test configuration should be moved into its own json configuration file like smoke-test.json in package root directory and this configuration can be used to opt package or any sample file out of smoke test.

@praveenkuttappan praveenkuttappan added the Central-EngSys This issue is owned by the Engineering System team. label Sep 22, 2020
@praveenkuttappan praveenkuttappan self-assigned this Sep 22, 2020
@ramya-rao-a
Copy link
Contributor

Currently smoke test configuration like whether package or any specific sample file is opted out is configured in main package.json in package root

@praveenkuttappan Can you add some pointers to a file or share examples for what you mean by the above?

@praveenkuttappan
Copy link
Member Author

@ramya-rao-a Here is an example of disabling smoke test using configuration in package.json. https://github.com/Azure/azure-sdk-for-js/blob/master/sdk/formrecognizer/ai-form-recognizer/package.json#L144

Issue is filed to isolate this configuration into a separate json file instead of putting them into package.json to keep package.json more of package and product specific rather than mixing with Engsys framework configuration.

@kurtzeborn
Copy link
Member

@benbp, is this even needed given the new smoke tests infrastructure?

@benbp
Copy link
Member

benbp commented Oct 20, 2020

@kurtzeborn the package.json based config was added for the new infra. I agree with @praveenkuttappan that we should move it out of that file into its own dedicated config. It would be nice for us to eventually standardize this config format as well as we roll out the model to other language repos.

openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this issue Nov 19, 2020
Swagger Correctness for Cognitive Services (Azure#11405)

* Swagger Correctness

* Undo changes in 2016-02-01-preview

* Move location of field

* change enum type to string for Sku.tier
@ramya-rao-a
Copy link
Contributor

Is #13007 related to this? If so, can we close this issue?

@benbp
Copy link
Member

benbp commented Feb 2, 2021

@ramya-rao-a yeah I think this is superseded by @willmtemple's work. Closing.

@benbp benbp closed this as completed Feb 2, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
None yet
Development

No branches or pull requests

4 participants