Response to PR Comments

sdk/search/search-documents/review/search-documents.api.md

@@ -541,10 +541,10 @@ export interface IndexingSchedule {
 }
 
 // @public
-export type IndexIterator = PagedAsyncIterableIterator<SearchIndex, SearchIndex[], Record<string, unknown>>;
+export type IndexIterator = PagedAsyncIterableIterator<SearchIndex, SearchIndex[], {}>;
 
 // @public
-export type IndexNameIterator = PagedAsyncIterableIterator<string, string[], Record<string, unknown>>;
+export type IndexNameIterator = PagedAsyncIterableIterator<string, string[], {}>;
 
 // @public
 export interface InputFieldMappingEntry {

sdk/search/search-documents/src/logger.ts

@@ -4,6 +4,6 @@
 import { createClientLogger } from "@azure/logger";
 
 /**
- * The \@azure/logger configuration for this package.
+ * The `@azure/logger` configuration for this package.
  */
 export const logger = createClientLogger("search");

sdk/search/search-documents/src/searchIndexingBufferedSenderImpl.ts

@@ -9,7 +9,8 @@ import {
   SearchIndexingBufferedSenderMergeDocumentsOptions,
   SearchIndexingBufferedSenderMergeOrUploadDocumentsOptions,
   SearchIndexingBufferedSenderDeleteDocumentsOptions,
-  SearchIndexingBufferedSenderFlushDocumentsOptions
+  SearchIndexingBufferedSenderFlushDocumentsOptions,
+  IndexDocumentsOptions
 } from "./indexModels";
 import { IndexDocumentsResult } from "./generated/data/models";
 import { RestError, OperationOptions } from "@azure/core-http";
@@ -19,7 +20,13 @@ import { CanonicalCode } from "@opentelemetry/api";
 import { SearchIndexingBufferedSender } from "./searchIndexingBufferedSender";
 import { delay } from "@azure/core-http";
 import { getRandomIntegerInclusive } from "./serviceUtils";
-import { SearchClient } from "./searchClient";
+
+interface IndexDocumentsClient<T> {
+  indexDocuments(
+    batch: IndexDocumentsBatch<T>,
+    options: IndexDocumentsOptions
+  ): Promise<IndexDocumentsResult>;
+}
 
 /**
  * Default Batch Size
@@ -50,7 +57,7 @@ class SearchIndexingBufferedSenderImpl<T> implements SearchIndexingBufferedSende
   /**
    * Search Client used to call the underlying IndexBatch operations.
    */
-  private client: SearchClient<T>;
+  private client: IndexDocumentsClient<T>;
   /**
    * Indicates if autoFlush is enabled.
    */
@@ -95,8 +102,7 @@ class SearchIndexingBufferedSenderImpl<T> implements SearchIndexingBufferedSende
    * @param options - Options to modify auto flush.
    *
    */
-  // eslint-disable-next-line @azure/azure-sdk/ts-use-interface-parameters
-  constructor(client: SearchClient<T>, options: SearchIndexingBufferedSenderOptions = {}) {
+  constructor(client: IndexDocumentsClient<T>, options: SearchIndexingBufferedSenderOptions = {}) {
     this.client = client;
     // General Configuration properties
     this.autoFlush = options.autoFlush ?? false;
@@ -411,9 +417,8 @@ class SearchIndexingBufferedSenderImpl<T> implements SearchIndexingBufferedSende
  * @param options - Options to modify auto flush.
  */
 export function createSearchIndexingBufferedSender<T>(
-  // eslint-disable-next-line @azure/azure-sdk/ts-use-interface-parameters
-  searchClient: SearchClient<T>,
+  indexDocumentsClient: IndexDocumentsClient<T>,
   options: SearchIndexingBufferedSenderOptions = {}
 ): SearchIndexingBufferedSender<T> {
-  return new SearchIndexingBufferedSenderImpl(searchClient, options);
+  return new SearchIndexingBufferedSenderImpl(indexDocumentsClient, options);
 }

sdk/search/search-documents/src/serialization.ts

@@ -24,7 +24,8 @@ export function deserialize<OutputT>(obj: unknown): OutputT {
 }
 
 function walk(start: unknown, mapper: (val: any) => any): any {
-  const seenMarker = new WeakMap<Record<string, unknown>, boolean>();
+  // eslint-disable-next-line @typescript-eslint/ban-types
+  const seenMarker = new WeakMap<object, boolean>();
   const result = { value: undefined };
   const queue: { value: any; parent: any; key: string }[] = [
     { value: start, parent: result, key: "value" }

sdk/search/search-documents/src/serviceModels.ts

@@ -381,7 +381,7 @@ export interface PatternAnalyzer {
   lowerCaseTerms?: boolean;
   /**
    * A regular expression pattern to match token separators. Default is an expression that matches
-   * one or more whitespace characters. Default value: '\\W+'.
+   * one or more whitespace characters. Default value: `\W+`.
    */
   pattern?: string;
   /**
@@ -479,7 +479,7 @@ export interface PatternTokenizer {
   name: string;
   /**
    * A regular expression pattern to match token separators. Default is an expression that matches
-   * one or more whitespace characters. Default value: '\\W+'.
+   * one or more whitespace characters. Default value: `\W+`.
    */
   pattern?: string;
   /**
@@ -862,22 +862,16 @@ export interface SynonymMap {
  * as needed during iteration. Use .byPage() to make one request to the server
  * per iteration.
  */
-export type IndexIterator = PagedAsyncIterableIterator<
-  SearchIndex,
-  SearchIndex[],
-  Record<string, unknown>
->;
+// eslint-disable-next-line @typescript-eslint/ban-types
+export type IndexIterator = PagedAsyncIterableIterator<SearchIndex, SearchIndex[], {}>;
 
 /**
  * An iterator for listing the indexes that exist in the Search service. Will make requests
  * as needed during iteration. Use .byPage() to make one request to the server
  * per iteration.
  */
-export type IndexNameIterator = PagedAsyncIterableIterator<
-  string,
-  string[],
-  Record<string, unknown>
->;
+// eslint-disable-next-line @typescript-eslint/ban-types
+export type IndexNameIterator = PagedAsyncIterableIterator<string, string[], {}>;
 
 /**
  * Represents a search index definition, which describes the fields and search behavior of an