Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate config methods for removed cache configuration. #42437

Merged
merged 3 commits into from
Oct 17, 2024
Merged

Deprecate config methods for removed cache configuration. #42437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ac75a52
Deprecate config methods for removed cache cnofiguration.
billwert Oct 17, 2024
a58a328
Update changelog to include PR link
billwert Oct 17, 2024
e5bf753
update changelog
billwert Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sdk/identity/azure-identity/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
### Bugs Fixed

### Other Changes
- `@Deprecated` methods `DefaultAzureCredential.setIntelliJKeePassDatabasePath` and `IntelliJCredentialBuilder.keePassDatabasePath`. [#42437](https://github.com/Azure/azure-sdk-for-java/pull/42437)

## 1.14.0 (2024-10-03)

Expand Down
4 changes: 1 addition & 3 deletions sdk/identity/azure-identity/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,12 +154,10 @@ See more about how to configure your IntelliJ IDEA in [Sign in Azure Toolkit for

```java
/**
* DefaultAzureCredential uses the KeePass database path to find the user account in IntelliJ on Windows.
* DefaultAzureCredential uses the signed-in user from Azure Toolkit for Java.
*/
public void createDefaultAzureCredentialForIntelliJ() {
DefaultAzureCredential defaultCredential = new DefaultAzureCredentialBuilder()
// KeePass configuration required only for Windows. No configuration needed for Linux / Mac
.intelliJKeePassDatabasePath("C:\\Users\\user\\AppData\\Roaming\\JetBrains\\IdeaIC2020.1\\c.kdbx")
.build();

// Azure SDK client builders accept the credential as a parameter
Expand Down
3 changes: 3 additions & 0 deletions ...entity/azure-identity/src/main/java/com/azure/identity/DefaultAzureCredentialBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,10 @@ public DefaultAzureCredentialBuilder authorityHost(String authorityHost) {
* @param databasePath the path to the KeePass database.
* @throws IllegalArgumentException if {@code databasePath} is either not specified or is empty.
* @return An updated instance of this builder with the KeePass database path set as specified.
* @deprecated Support for older Azure Toolkit for IntelliJ versions was
* <a href="https://aka.ms/azsdk/java/identity/intellij-credential-update">removed in 1.14.0.</a>
*/
@Deprecated
public DefaultAzureCredentialBuilder intelliJKeePassDatabasePath(String databasePath) {
if (CoreUtils.isNullOrEmpty(databasePath)) {
throw LOGGER.logExceptionAsError(
Expand Down
3 changes: 3 additions & 0 deletions sdk/identity/azure-identity/src/main/java/com/azure/identity/IntelliJCredentialBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,10 @@ public IntelliJCredentialBuilder tenantId(String tenantId) {
* @param databasePath the path to the KeePass database.
* @throws IllegalArgumentException if {@code databasePath} is either not specified or is empty.
* @return An updated instance of this builder with the KeePass database path set as specified.
* @deprecated Support for older Azure Toolkit for IntelliJ versions was
* <a href="https://aka.ms/azsdk/java/identity/intellij-credential-update">removed in 1.14.0.</a>
*/
@Deprecated
public IntelliJCredentialBuilder keePassDatabasePath(String databasePath) {
if (CoreUtils.isNullOrEmpty(databasePath)) {
throw LOGGER.logExceptionAsError(
Expand Down