Api Review Changes #38587
Merged
Api Review Changes #38587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ibrandes
commented
Feb 1, 2024
•
ibrandes
commented
- making getEncryptionScope protected and editing cpkn async test
- chaning isRenameSupported
- removing bool readtofile overload
- adding readtofile and getproperties methods to async clients
- changing upn to UserPrincipalNam
- making sync and async getPropertiesWithResponse upn methods private, and fixing the overloads that were breaking changes
|
API change check APIView has identified API level changes in this PR and created following API reviews. com.azure:azure-storage-blob |
ibrandes
requested review from
ibrahimrabab,
alzimmermsft and
seanmcc-msft
as code owners
ibrahimrabab
reviewed
Feb 5, 2024
...azure-storage-blob/src/main/java/com/azure/storage/blob/specialized/BlobAsyncClientBase.java
Show resolved
Hide resolved
ibrahimrabab
approved these changes
Feb 7, 2024
alzimmermsft
requested changes
Feb 9, 2024
.../azure-storage-blob/src/test/java/com/azure/storage/blob/specialized/BlobBaseTestHelper.java
Outdated
Show resolved
Hide resolved
...e-file-datalake/src/main/java/com/azure/storage/file/datalake/options/ReadToFileOptions.java
Outdated
Show resolved
Hide resolved
| * @return A reactive response containing the resource's properties and metadata. | ||
| */ | ||
| @ServiceMethod(returns = ReturnType.SINGLE) | ||
| public Mono<Response<PathProperties>> getPropertiesWithResponse(PathGetPropertiesOptions options) { |
There was a problem hiding this comment.
Unfortunately, this API is a breaking change due to the ambiguous call site (reason why in tests you needed to type cast the null being passed).
We'll need to think of a different name for this method to prevent this breaking change. Maybe getPropertiesUsingOptionsWithResponse?
There was a problem hiding this comment.
Decided to remove this and the sync method and make them private.
ibrandes
merged commit 4e32459
into
Azure:feature/storage/stg93base
16 of 19 checks passed
ibrandes
added a commit
that referenced
this pull request
Apr 4, 2024
* Adding new service version 2024-05-04 (2nd try) (#38255) * file changes * asset files * fixing audience error test without instrument * accidentally did not commit the change lol * re-enabling ClientName in HandleItem (#38273) * STG93 Adding rename support In List Range (Diff Range) (#38324) * swagger * hooking up * test and recording * style * async test * style * changing get to is * adding javadoc description and changing names * STG93 Added ACL response headers and x-ms-upn request header (#38450) * implementation * reformatting context logic, acl test, unfunctional upn test * edit to parseList in PathAccessControlEntry * style * made upn header appear in request and finished upn test * fixing issue with pipeline * making upn context adjustment its own method and editing its usage * fixing pipeline again * fixing upn test * resolving comments * Stg93 Snapshot management support via REST for NFS shares (Cleaned) (#38845) * swagger and hookup * everything * style * removing preprod from test environment suffix * adding better descriptions * renaming * re-recording * Revert "Stg93 Snapshot management support via REST for NFS shares (Cleaned) (…" (#38859) This reverts commit 3b390e6. * Api Review Changes (#38587) * all api review changes * syntax * revisions * removing imports * removing overwrite variable * CPKN async edits * docs changes * making getPropertiesWithResponse in sync and async private, fixing breaking change in sync * style * recording fixes * re-recording a test and suppressing spotbugs errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.