-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Api Review Changes #38587
Api Review Changes #38587
Conversation
ibrandes
commented
Feb 1, 2024
•
edited
Loading
edited
- making getEncryptionScope protected and editing cpkn async test
- chaning isRenameSupported
- removing bool readtofile overload
- adding readtofile and getproperties methods to async clients
- changing upn to UserPrincipalNam
- making sync and async getPropertiesWithResponse upn methods private, and fixing the overloads that were breaking changes
API change check APIView has identified API level changes in this PR and created following API reviews. com.azure:azure-storage-blob |
...azure-storage-blob/src/main/java/com/azure/storage/blob/specialized/BlobAsyncClientBase.java
Show resolved
Hide resolved
.../azure-storage-blob/src/test/java/com/azure/storage/blob/specialized/BlobBaseTestHelper.java
Outdated
Show resolved
Hide resolved
...e-file-datalake/src/main/java/com/azure/storage/file/datalake/options/ReadToFileOptions.java
Outdated
Show resolved
Hide resolved
* @return A reactive response containing the resource's properties and metadata. | ||
*/ | ||
@ServiceMethod(returns = ReturnType.SINGLE) | ||
public Mono<Response<PathProperties>> getPropertiesWithResponse(PathGetPropertiesOptions options) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, this API is a breaking change due to the ambiguous call site (reason why in tests you needed to type cast the null being passed).
We'll need to think of a different name for this method to prevent this breaking change. Maybe getPropertiesUsingOptionsWithResponse
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Decided to remove this and the sync method and make them private.
4e32459
into
Azure:feature/storage/stg93base
* Adding new service version 2024-05-04 (2nd try) (#38255) * file changes * asset files * fixing audience error test without instrument * accidentally did not commit the change lol * re-enabling ClientName in HandleItem (#38273) * STG93 Adding rename support In List Range (Diff Range) (#38324) * swagger * hooking up * test and recording * style * async test * style * changing get to is * adding javadoc description and changing names * STG93 Added ACL response headers and x-ms-upn request header (#38450) * implementation * reformatting context logic, acl test, unfunctional upn test * edit to parseList in PathAccessControlEntry * style * made upn header appear in request and finished upn test * fixing issue with pipeline * making upn context adjustment its own method and editing its usage * fixing pipeline again * fixing upn test * resolving comments * Stg93 Snapshot management support via REST for NFS shares (Cleaned) (#38845) * swagger and hookup * everything * style * removing preprod from test environment suffix * adding better descriptions * renaming * re-recording * Revert "Stg93 Snapshot management support via REST for NFS shares (Cleaned) (…" (#38859) This reverts commit 3b390e6. * Api Review Changes (#38587) * all api review changes * syntax * revisions * removing imports * removing overwrite variable * CPKN async edits * docs changes * making getPropertiesWithResponse in sync and async private, fixing breaking change in sync * style * recording fixes * re-recording a test and suppressing spotbugs errors