-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stg93 Snapshot management support via REST for NFS shares #38329
Closed
ibrandes
wants to merge
9
commits into
Azure:feature/storage/stg93base
from
ibrandes:stg93SnapshotManagement
Closed
Stg93 Snapshot management support via REST for NFS shares #38329
ibrandes
wants to merge
9
commits into
Azure:feature/storage/stg93base
from
ibrandes:stg93SnapshotManagement
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API change check API changes are not detected in this pull request. |
ibrandes
requested review from
ibrahimrabab,
alzimmermsft and
seanmcc-msft
as code owners
January 17, 2024 19:30
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, let's also have Rabab or someone on the Azure SDK side take a look.
...torage-file-share/src/main/java/com/azure/storage/file/share/options/ShareCreateOptions.java
Outdated
Show resolved
Hide resolved
...torage-file-share/src/main/java/com/azure/storage/file/share/options/ShareCreateOptions.java
Outdated
Show resolved
Hide resolved
alzimmermsft
approved these changes
Jan 26, 2024
…azure-sdk-for-java into stg93SnapshotManagement
ibrandes
requested review from
joshfree,
JonathanGiles,
samvaity,
g2vinay,
chenrujun,
Netyyyy,
saragluna,
moarychan,
JimSuplizio,
weidongxu-microsoft,
haolingdong-msft and
XiaofeiCao
as code owners
February 20, 2024 21:27
ibrandes
removed request for
Netyyyy,
XiaofeiCao,
besh2014,
shwali-msft,
Aashish93-stack,
mikehang-msft,
gfeitosa-msft,
allchiang-msft,
phermanov-msft,
ilyapaliakou-msft,
a team,
AikoBB,
maximrytych-ms,
mjafferi-msft,
juntuchen-msft,
cochi2,
minwoolee-msft,
skapur12,
wiboris,
dpwatrous,
NickKouds,
anilba06,
gkostal,
LarryOsterman,
jsquire and
ronniegeraghty
February 20, 2024 21:28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STG93 feature for enabling snapshot virtual directory acccess.
(sorry for requesting review from 100 people)