Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoPR applicationinsights/resource-manager] [App Insights control plane] fix: validate subId, apiVersion, rgName #3250

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions applicationinsights/resource-manager/v2015_05_01/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,15 @@
<parent>
<groupId>com.microsoft.azure</groupId>
<artifactId>azure-arm-parent</artifactId>
<version>1.0.0</version>
<version>0.0.3-beta</version>
<relativePath>../../../pom.xml</relativePath>
</parent>
<artifactId>azure-mgmt-insights</artifactId>
<version>1.0.0-beta</version>
<packaging>jar</packaging>
<name>Microsoft Azure SDK for Insights Management</name>
<description>This package contains Microsoft Insights Management SDK.</description>
<url>https://github.com/Azure/azure-libraries-for-java</url>
<url>https://github.com/Azure/azure-sdk-for-java</url>
<licenses>
<license>
<name>The MIT License (MIT)</name>
Expand All @@ -28,8 +28,8 @@
</license>
</licenses>
<scm>
<url>scm:git:https://github.com/Azure/azure-libraries-for-java</url>
<connection>scm:git:git@github.com:Azure/azure-libraries-for-java.git</connection>
<url>scm:git:https://github.com/Azure/azure-sdk-for-java</url>
<connection>scm:git:git@github.com:Azure/azure-sdk-for-java.git</connection>
<tag>HEAD</tag>
</scm>
<properties>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
import com.fasterxml.jackson.annotation.JsonProperty;

/**
* An Application Insights component API Key createion request definition.
* An Application Insights component API Key creation request definition.
*/
public class APIKeyRequest {
/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ public interface APIKeys extends HasInner<APIKeysInner> {
/**
* Get the API Key for this key id.
*
* @param resourceGroupName The name of the resource group.
* @param resourceGroupName The name of the resource group. The name is case insensitive.
* @param resourceName The name of the Application Insights component resource.
* @param keyId The API Key ID. This is unique within a Application Insights component.
* @throws IllegalArgumentException thrown if parameters fail the validation
Expand All @@ -31,7 +31,7 @@ public interface APIKeys extends HasInner<APIKeysInner> {
/**
* Gets a list of API keys of an Application Insights component.
*
* @param resourceGroupName The name of the resource group.
* @param resourceGroupName The name of the resource group. The name is case insensitive.
* @param resourceName The name of the Application Insights component resource.
* @throws IllegalArgumentException thrown if parameters fail the validation
* @return the observable for the request
Expand All @@ -41,7 +41,7 @@ public interface APIKeys extends HasInner<APIKeysInner> {
/**
* Delete an API Key of an Application Insights component.
*
* @param resourceGroupName The name of the resource group.
* @param resourceGroupName The name of the resource group. The name is case insensitive.
* @param resourceName The name of the Application Insights component resource.
* @param keyId The API Key ID. This is unique within a Application Insights component.
* @throws IllegalArgumentException thrown if parameters fail the validation
Expand All @@ -52,7 +52,7 @@ public interface APIKeys extends HasInner<APIKeysInner> {
/**
* Create an API Key of an Application Insights component.
*
* @param resourceGroupName The name of the resource group.
* @param resourceGroupName The name of the resource group. The name is case insensitive.
* @param resourceName The name of the Application Insights component resource.
* @param aPIKeyProperties Properties that need to be specified to create an API key of a Application Insights component.
* @throws IllegalArgumentException thrown if parameters fail the validation
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public interface AnalyticsItems extends HasInner<AnalyticsItemsInner> {
/**
* Gets a list of Analytics Items defined within an Application Insights component.
*
* @param resourceGroupName The name of the resource group.
* @param resourceGroupName The name of the resource group. The name is case insensitive.
* @param resourceName The name of the Application Insights component resource.
* @param scopePath Enum indicating if this item definition is owned by a specific user or is shared between all users with access to the Application Insights component. Possible values include: 'analyticsItems', 'myanalyticsItems'
* @throws IllegalArgumentException thrown if parameters fail the validation
Expand All @@ -32,7 +32,7 @@ public interface AnalyticsItems extends HasInner<AnalyticsItemsInner> {
/**
* Gets a specific Analytics Items defined within an Application Insights component.
*
* @param resourceGroupName The name of the resource group.
* @param resourceGroupName The name of the resource group. The name is case insensitive.
* @param resourceName The name of the Application Insights component resource.
* @param scopePath Enum indicating if this item definition is owned by a specific user or is shared between all users with access to the Application Insights component. Possible values include: 'analyticsItems', 'myanalyticsItems'
* @throws IllegalArgumentException thrown if parameters fail the validation
Expand All @@ -43,7 +43,7 @@ public interface AnalyticsItems extends HasInner<AnalyticsItemsInner> {
/**
* Adds or Updates a specific Analytics Item within an Application Insights component.
*
* @param resourceGroupName The name of the resource group.
* @param resourceGroupName The name of the resource group. The name is case insensitive.
* @param resourceName The name of the Application Insights component resource.
* @param scopePath Enum indicating if this item definition is owned by a specific user or is shared between all users with access to the Application Insights component. Possible values include: 'analyticsItems', 'myanalyticsItems'
* @param itemProperties Properties that need to be specified to create a new item and add it to an Application Insights component.
Expand All @@ -55,7 +55,7 @@ public interface AnalyticsItems extends HasInner<AnalyticsItemsInner> {
/**
* Deletes a specific Analytics Items defined within an Application Insights component.
*
* @param resourceGroupName The name of the resource group.
* @param resourceGroupName The name of the resource group. The name is case insensitive.
* @param resourceName The name of the Application Insights component resource.
* @param scopePath Enum indicating if this item definition is owned by a specific user or is shared between all users with access to the Application Insights component. Possible values include: 'analyticsItems', 'myanalyticsItems'
* @throws IllegalArgumentException thrown if parameters fail the validation
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public interface Annotations extends HasInner<AnnotationsInner> {
/**
* Create an Annotation of an Application Insights component.
*
* @param resourceGroupName The name of the resource group.
* @param resourceGroupName The name of the resource group. The name is case insensitive.
* @param resourceName The name of the Application Insights component resource.
* @param annotationProperties Properties that need to be specified to create an annotation of a Application Insights component.
* @throws IllegalArgumentException thrown if parameters fail the validation
Expand All @@ -32,7 +32,7 @@ public interface Annotations extends HasInner<AnnotationsInner> {
/**
* Get the annotation for given id.
*
* @param resourceGroupName The name of the resource group.
* @param resourceGroupName The name of the resource group. The name is case insensitive.
* @param resourceName The name of the Application Insights component resource.
* @param annotationId The unique annotation ID. This is unique within a Application Insights component.
* @throws IllegalArgumentException thrown if parameters fail the validation
Expand All @@ -43,7 +43,7 @@ public interface Annotations extends HasInner<AnnotationsInner> {
/**
* Gets the list of annotations for a component for given time range.
*
* @param resourceGroupName The name of the resource group.
* @param resourceGroupName The name of the resource group. The name is case insensitive.
* @param resourceName The name of the Application Insights component resource.
* @param start The start time to query from for annotations, cannot be older than 90 days from current date.
* @param end The end time to query for annotations.
Expand All @@ -55,7 +55,7 @@ public interface Annotations extends HasInner<AnnotationsInner> {
/**
* Delete an Annotation of an Application Insights component.
*
* @param resourceGroupName The name of the resource group.
* @param resourceGroupName The name of the resource group. The name is case insensitive.
* @param resourceName The name of the Application Insights component resource.
* @param annotationId The unique annotation ID. This is unique within a Application Insights component.
* @throws IllegalArgumentException thrown if parameters fail the validation
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,9 @@ interface WithGroup extends GroupableResourceCore.DefinitionStages.WithGroup<Wit
interface WithApplicationType {
/**
* Specifies applicationType.
*/
* @param applicationType Type of application being monitored. Possible values include: 'web', 'other'
* @return the next definition stage
*/
WithKind withApplicationType(ApplicationType applicationType);
}

Expand All @@ -128,46 +130,56 @@ interface WithApplicationType {
interface WithKind {
/**
* Specifies kind.
*/
* @param kind The kind of application that this component refers to, used to customize UI. This value is a freeform string, values should typically be one of the following: web, ios, other, store, java, phone
* @return the next definition stage
*/
WithCreate withKind(String kind);
}

/**
* The stage of the applicationinsightscomponent update allowing to specify FlowType.
* The stage of the applicationinsightscomponent definition allowing to specify FlowType.
*/
interface WithFlowType {
/**
* Specifies flowType.
* @param flowType Used by the Application Insights system to determine what kind of flow this component was created by. This is to be set to 'Bluefield' when creating/updating a component via the REST API. Possible values include: 'Bluefield'
* @return the next definition stage
*/
WithCreate withFlowType(FlowType flowType);
}

/**
* The stage of the applicationinsightscomponent update allowing to specify HockeyAppId.
* The stage of the applicationinsightscomponent definition allowing to specify HockeyAppId.
*/
interface WithHockeyAppId {
/**
* Specifies hockeyAppId.
* @param hockeyAppId The unique application ID created when a new application is added to HockeyApp, used for communications with HockeyApp
* @return the next definition stage
*/
WithCreate withHockeyAppId(String hockeyAppId);
}

/**
* The stage of the applicationinsightscomponent update allowing to specify RequestSource.
* The stage of the applicationinsightscomponent definition allowing to specify RequestSource.
*/
interface WithRequestSource {
/**
* Specifies requestSource.
* @param requestSource Describes what tool created this Application Insights component. Customers using this API should set this to the default 'rest'. Possible values include: 'rest'
* @return the next definition stage
*/
WithCreate withRequestSource(RequestSource requestSource);
}

/**
* The stage of the applicationinsightscomponent update allowing to specify SamplingPercentage.
* The stage of the applicationinsightscomponent definition allowing to specify SamplingPercentage.
*/
interface WithSamplingPercentage {
/**
* Specifies samplingPercentage.
* @param samplingPercentage Percentage of the data produced by the application being monitored that is being sampled for Application Insights telemetry
* @return the next definition stage
*/
WithCreate withSamplingPercentage(Double samplingPercentage);
}
Expand All @@ -191,41 +203,49 @@ interface Update extends Appliable<ApplicationInsightsComponent>, Resource.Updat
*/
interface UpdateStages {
/**
* The stage of the applicationinsightscomponent {0} allowing to specify FlowType.
* The stage of the applicationinsightscomponent update allowing to specify FlowType.
*/
interface WithFlowType {
/**
* Specifies flowType.
* @param flowType Used by the Application Insights system to determine what kind of flow this component was created by. This is to be set to 'Bluefield' when creating/updating a component via the REST API. Possible values include: 'Bluefield'
* @return the next update stage
*/
Update withFlowType(FlowType flowType);
}

/**
* The stage of the applicationinsightscomponent {0} allowing to specify HockeyAppId.
* The stage of the applicationinsightscomponent update allowing to specify HockeyAppId.
*/
interface WithHockeyAppId {
/**
* Specifies hockeyAppId.
* @param hockeyAppId The unique application ID created when a new application is added to HockeyApp, used for communications with HockeyApp
* @return the next update stage
*/
Update withHockeyAppId(String hockeyAppId);
}

/**
* The stage of the applicationinsightscomponent {0} allowing to specify RequestSource.
* The stage of the applicationinsightscomponent update allowing to specify RequestSource.
*/
interface WithRequestSource {
/**
* Specifies requestSource.
* @param requestSource Describes what tool created this Application Insights component. Customers using this API should set this to the default 'rest'. Possible values include: 'rest'
* @return the next update stage
*/
Update withRequestSource(RequestSource requestSource);
}

/**
* The stage of the applicationinsightscomponent {0} allowing to specify SamplingPercentage.
* The stage of the applicationinsightscomponent update allowing to specify SamplingPercentage.
*/
interface WithSamplingPercentage {
/**
* Specifies samplingPercentage.
* @param samplingPercentage Percentage of the data produced by the application being monitored that is being sampled for Application Insights telemetry
* @return the next update stage
*/
Update withSamplingPercentage(Double samplingPercentage);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
import com.fasterxml.jackson.annotation.JsonProperty;

/**
* An Application Insights component daily data volumne cap.
* An Application Insights component daily data volume cap.
*/
public class ApplicationInsightsComponentDataVolumeCap {
/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,9 @@ interface Blank extends WithComponent {
interface WithComponent {
/**
* Specifies resourceGroupName, resourceName.
* @param resourceGroupName The name of the resource group. The name is case insensitive
* @param resourceName The name of the Application Insights component resource
* @return the next definition stage
*/
WithCreate withExistingComponent(String resourceGroupName, String resourceName);
}
Expand All @@ -107,6 +110,8 @@ interface WithComponent {
interface WithCategory {
/**
* Specifies category.
* @param category Favorite category, as defined by the user at creation time
* @return the next definition stage
*/
WithCreate withCategory(String category);
}
Expand All @@ -117,6 +122,8 @@ interface WithCategory {
interface WithConfig {
/**
* Specifies config.
* @param config Configuration of this particular favorite, which are driven by the Azure portal UX. Configuration data is a string containing valid JSON
* @return the next definition stage
*/
WithCreate withConfig(String config);
}
Expand All @@ -127,6 +134,8 @@ interface WithConfig {
interface WithFavoriteType {
/**
* Specifies favoriteType.
* @param favoriteType Enum indicating if this favorite definition is owned by a specific user or is shared between all users with access to the Application Insights component. Possible values include: 'shared', 'user'
* @return the next definition stage
*/
WithCreate withFavoriteType(FavoriteType favoriteType);
}
Expand All @@ -137,6 +146,8 @@ interface WithFavoriteType {
interface WithIsGeneratedFromTemplate {
/**
* Specifies isGeneratedFromTemplate.
* @param isGeneratedFromTemplate Flag denoting wether or not this favorite was generated from a template
* @return the next definition stage
*/
WithCreate withIsGeneratedFromTemplate(Boolean isGeneratedFromTemplate);
}
Expand All @@ -147,6 +158,8 @@ interface WithIsGeneratedFromTemplate {
interface WithName {
/**
* Specifies name.
* @param name The user-defined name of the favorite
* @return the next definition stage
*/
WithCreate withName(String name);
}
Expand All @@ -157,6 +170,8 @@ interface WithName {
interface WithSourceType {
/**
* Specifies sourceType.
* @param sourceType The source of the favorite definition
* @return the next definition stage
*/
WithCreate withSourceType(String sourceType);
}
Expand All @@ -167,6 +182,8 @@ interface WithSourceType {
interface WithTags {
/**
* Specifies tags.
* @param tags A list of 0 or more tags that are associated with this favorite definition
* @return the next definition stage
*/
WithCreate withTags(List<String> tags);
}
Expand All @@ -177,6 +194,8 @@ interface WithTags {
interface WithVersion {
/**
* Specifies version.
* @param version This instance's version of the data model. This can change as new features are added that can be marked favorite. Current examples include MetricsExplorer (ME) and Search
* @return the next definition stage
*/
WithCreate withVersion(String version);
}
Expand Down
Loading