Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KeyVault updating versions for release #3149

Merged
merged 3 commits into from
Mar 20, 2019
Merged

KeyVault updating versions for release #3149

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9a219d7
KeyVault updating versions for release
schaabs Mar 19, 2019
008e0b1
updating missed parent version
schaabs Mar 19, 2019
84eddee
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-java …
schaabs Mar 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion keyvault/data-plane/azure-keyvault-complete/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ the MIT License. See License.txt in the project root for license information. --

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You didn't update the parent pom version here like you did the other places.

<groupId>com.microsoft.azure</groupId>
<artifactId>azure-keyvault-complete</artifactId>
<version>1.2.0</version>
<version>1.2.1</version>
<packaging>pom</packaging>

<name>Microsoft Azure Key Vault SDK Complete</name>
Expand Down
4 changes: 2 additions & 2 deletions keyvault/data-plane/azure-keyvault-core/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,13 @@
<parent>
<groupId>com.microsoft.azure</groupId>
<artifactId>azure-keyvault-parent</artifactId>
<version>1.2.0</version>
<version>1.2.1</version>
<relativePath>../pom.xml</relativePath>
</parent>

<groupId>com.microsoft.azure</groupId>
<artifactId>azure-keyvault-core</artifactId>
<version>1.2.0</version>
<version>1.2.1</version>
<packaging>jar</packaging>

<name>Microsoft Azure SDK for Key Vault Core</name>
Expand Down
4 changes: 2 additions & 2 deletions keyvault/data-plane/azure-keyvault-cryptography/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,13 @@
<parent>
<groupId>com.microsoft.azure</groupId>
<artifactId>azure-keyvault-parent</artifactId>
<version>1.2.0</version>
<version>1.2.1</version>
<relativePath>../pom.xml</relativePath>
</parent>

<groupId>com.microsoft.azure</groupId>
<artifactId>azure-keyvault-cryptography</artifactId>
<version>1.2.0</version>
<version>1.2.1</version>
<packaging>jar</packaging>

<name>Microsoft Azure SDK for Key Vault Cryptography</name>
Expand Down
4 changes: 2 additions & 2 deletions keyvault/data-plane/azure-keyvault-extensions/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@
<parent>
<groupId>com.microsoft.azure</groupId>
<artifactId>azure-keyvault-parent</artifactId>
<version>1.2.0</version>
<version>1.2.1</version>
<relativePath>../pom.xml</relativePath>
</parent>

<artifactId>azure-keyvault-extensions</artifactId>
<version>1.2.0</version>
<version>1.2.1</version>
<packaging>jar</packaging>

<name>Microsoft Azure SDK for Key Vault Extensions</name>
Expand Down
2 changes: 1 addition & 1 deletion keyvault/data-plane/azure-keyvault-test/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
<parent>
<groupId>com.microsoft.azure</groupId>
<artifactId>azure-keyvault-parent</artifactId>
<version>1.2.0</version>
<version>1.2.1</version>
<relativePath>../pom.xml</relativePath>
</parent>
<artifactId>azure-keyvault-test</artifactId>
Expand Down
4 changes: 2 additions & 2 deletions keyvault/data-plane/azure-keyvault-webkey/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,12 @@
<parent>
<groupId>com.microsoft.azure</groupId>
<artifactId>azure-keyvault-parent</artifactId>
<version>1.2.0</version>
<version>1.2.1</version>
<relativePath>../pom.xml</relativePath>
</parent>

<artifactId>azure-keyvault-webkey</artifactId>
<version>1.2.0</version>
<version>1.2.1</version>
<packaging>jar</packaging>

<name>Microsoft Azure SDK for Key Vault WebKey</name>
Expand Down
4 changes: 2 additions & 2 deletions keyvault/data-plane/azure-keyvault/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,13 @@ the MIT License. See License.txt in the project root for license information. --
<parent>
<groupId>com.microsoft.azure</groupId>
<artifactId>azure-keyvault-parent</artifactId>
<version>1.2.0</version>
<version>1.2.1</version>
<relativePath>../pom.xml</relativePath>
</parent>

<groupId>com.microsoft.azure</groupId>
<artifactId>azure-keyvault</artifactId>
<version>1.2.0</version>
<version>1.2.1</version>
<packaging>jar</packaging>

<name>Microsoft Azure SDK for Key Vault</name>
Expand Down
4 changes: 2 additions & 2 deletions keyvault/data-plane/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
<relativePath>../../pom.client.xml</relativePath>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JonathanGiles do you know if having a reference a SNAPSHOT version for the parent pom will cause any issues for people consuming this JAR if we publish a non-SNAPSHOT version of these packages?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather that we start publishing releases of all 'pom' artifacts as releases, rather than snapshots. I am happy with versioning it as 1.0.0 or 1.0.0-rc1 (or -alpha1 / -beta1, but I think -rc1 is probably best).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So your suggesting that we also publish the parent poms at the same time? Would you suggest we do that as on-off or every time we publish a package? If we do it every time that would seem like we would need to version these parent POMs often.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would only publish new pom releases when they have changed. In the short term this will be more frequent than a bit further down the road when we reach more of a steady state.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And to clarify, yes, versions will increment each time and often. I am ok with that. I would like to ensure that all child modules kept current with the latest versions also (so when key vault depends on a newer version, we would also update batch, event hubs, etc).

</parent>

<version>1.2.0</version>
<version>1.2.1</version>
<groupId>com.microsoft.azure</groupId>
<artifactId>azure-keyvault-parent</artifactId>
<packaging>pom</packaging>
Expand All @@ -34,7 +34,7 @@
</scm>

<properties>
<azure-keyvault.version>1.2.0</azure-keyvault.version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason you aren't using this version in all the individual keyvault pom files that is importing this as a parent pom? That would reduce copy and paste effort.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After reading a little about using this approach it sounds like there are some weird issues so for now lets just make sure we update all the places.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is where having the versions.txt approach I discussed with @weshaggard would be very useful.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree.

<azure-keyvault.version>1.2.1</azure-keyvault.version>
</properties>

<dependencyManagement>
Expand Down