Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EventHubs integration part 2 - spotbugs #3105

Merged
merged 55 commits into from
Mar 21, 2019
Merged

EventHubs integration part 2 - spotbugs #3105

Changes from 1 commit
Commits
Show all changes
55 commits
Select commit Hold shift + click to select a range
a0a9256
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-java …
mssfang Mar 7, 2019
448eb87
eventhubs-java: pom and code changes
mssfang Mar 5, 2019
81bf995
eventhubs-java: client.test.live.yml updated
mssfang Mar 5, 2019
cbdcbc4
LicenseJava: add license info for all java files
mssfang Mar 6, 2019
63202b8
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-java …
mssfang Mar 8, 2019
2b77b7e
PR-3067: Eventhub-java: integrate event hubs into azure-sdk-for-java …
mssfang Mar 8, 2019
b3f9025
fix: update jproxy link for unit tests
mssfang Mar 11, 2019
7e62e12
Merge branch 'master' into eventhub-after-init
mssfang Mar 11, 2019
6205425
fix<test-proxy-server>: add external proxy server lib source file for…
mssfang Mar 11, 2019
d428a0b
fix<checkstyle>: fixed all indentation errors
mssfang Mar 13, 2019
7ca54ae
fix<checkstyle>: FileTabCharacter rule fixed
mssfang Mar 13, 2019
77f60ad
fix<checkstyle>: fixed OperatorWrap rule
mssfang Mar 13, 2019
6af1c75
fix<checkStyle>: fixed AvoidStarImport rule
mssfang Mar 13, 2019
2f659da
fix<checkstyle>: WhitespaceAround rule
mssfang Mar 13, 2019
d27ff38
fix<checkstyle>: NoWhitespaceBefore and WhitespaceAfter rules
mssfang Mar 13, 2019
d74dd65
fix<checkstyle>: WhitespaceAround rule
mssfang Mar 13, 2019
370ac79
fix<checkstyle>: RegexpSingleline rule
mssfang Mar 13, 2019
490ba69
fix<checkstyle>: ArrayTypeStyle rule
mssfang Mar 13, 2019
aa398e5
fix<checkstyle>: NewlineAtEndOfFile rule
mssfang Mar 13, 2019
0186bde
fix<checkstyle>: UnusedImports
mssfang Mar 13, 2019
ad9e36e
fix<checkstyle>: ConstantName
mssfang Mar 13, 2019
1bdd20c
fix<checkstyle>: MethodName and StaticVariableName rules
mssfang Mar 13, 2019
8b1c784
fix<checkstyle>: VisibilityModifier
mssfang Mar 13, 2019
7ef1d6f
fix<checkstyle>: EmptyBlock, InnerAssignment
mssfang Mar 13, 2019
175b3c0
fix<checkstyle>: ModifierOrder
mssfang Mar 13, 2019
6b62e9e
fix<checkstyle>: RedundantModifier
mssfang Mar 13, 2019
442091a
fix<checkstyle-warning>: LeftCurly
mssfang Mar 13, 2019
630824a
fix<revert>: revert client.test.live.yml changes, exclude event hub
mssfang Mar 13, 2019
efa2053
fix<checkstyle>: additional 10 Indentation errors
mssfang Mar 14, 2019
e1b698a
fix<checkstyle, pom>: updates changes for connie's code changes request
mssfang Mar 14, 2019
0071253
fix<conflict>: resolved conflict after update
mssfang Mar 14, 2019
7452fbd
test<live-test>: enable live test for eventhubs
mssfang Mar 14, 2019
544218e
fix<SpotBugs>: all 6 P1 bugs
mssfang Mar 14, 2019
1e440f9
fix<SpotBugs>: supression and refactor
mssfang Mar 14, 2019
c518a23
fix<SpotBugs>: update spotbugs-exclude with comment for EH
mssfang Mar 14, 2019
03e37c8
refactor(SpotBugs): import static
mssfang Mar 14, 2019
3aa6471
fix<checkstyle>: access can be package-private
mssfang Mar 14, 2019
d508260
fix<checkstyle>: modifier public is redundant for interface methods
mssfang Mar 14, 2019
e4ef6ac
fix<checkstyle>: modifier public is redundant for inner class of inte…
mssfang Mar 14, 2019
6ed1f7a
fix<checkstyle>: modifier final is redundant for final class
mssfang Mar 14, 2019
2c32224
Merge branch 'master' into eventhubs-spotbugs
mssfang Mar 15, 2019
79cd1f0
fix(stylecheck): EmptyBlock
mssfang Mar 18, 2019
146633f
fix(CheckStyle): EmptyBlock and ConstantName
mssfang Mar 18, 2019
49fbbbe
fix(CheckStyle): MethodName
mssfang Mar 18, 2019
e527b56
fix(CheckStyle): ConstantName
mssfang Mar 18, 2019
6d28c99
fix(CheckStyle): checkstyle suppressions file
mssfang Mar 18, 2019
a35f40e
Merge branch 'master' into eventhubs-spotbugs
mssfang Mar 18, 2019
8f9a73d
fix(CheckStyle): refactor Inner Assignment
mssfang Mar 19, 2019
8b88512
fix(CheckStyle): refactor Empty Block
mssfang Mar 19, 2019
2b48635
fix(CheckStyle): update Check Style Suppressions
mssfang Mar 19, 2019
4c18e9f
Merge branch 'eventhubs-spotbugs' of https://github.com/mssfang/azure…
mssfang Mar 19, 2019
5a69d29
fix(CheckStyle): after update to checkstyle 8.18, final modifier modi…
mssfang Mar 19, 2019
75299c8
Merge branch 'master' into eventhubs-spotbugs
mssfang Mar 19, 2019
d23c604
docs(CheckStyle): clarity the comment, no functional things involved
mssfang Mar 21, 2019
fdbe56a
conflict: resolved eventhubs conflict
mssfang Mar 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 2 additions & 11 deletions eng/code-quality-reports/src/main/resources/checkstyle/checkstyle-suppressions.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
<!-- Public API already released with incorrect upper-case naming pattern -->
<suppress checks="MethodName" files="AsymmetricEncryptionAlgorithm.java"/>
<suppress checks="MethodName" files="KeyWrapAlgorithm.java"/>
<suppress checks="MethodName" files="PartitionSenderImpl.java"/>
<suppress checks="MethodName" files="SignatureEncoding.java"/>
<suppress checks="MethodName" files="SymmetricEncryptionAlgorithm.java"/>
<suppress checks="MethodName" files="RsaSignature.java"/>
Expand All @@ -31,13 +30,8 @@
<suppress checks="ConstantName" files="AlgorithmResolver.java"/>
<suppress checks="ConstantName" files="AmqpErrorCode.java"/>
<suppress checks="ConstantName" files="BatchErrorCodeStrings.java"/>
<suppress checks="ConstantName" files="ConnectionStringBuilder.java"/>
<suppress checks="ConstantName" files="EventProcessorHost.java"/>
<suppress checks="ConstantName" files="InMemoryCheckpointManager.java"/>
<suppress checks="ConstantName" files="InMemoryLeaseManager.java"/>
<suppress checks="ConstantName" files="MessagingFactory.java"/>
<suppress checks="ConstantName" files="PartitionManagerOptions.java"/>
<suppress checks="ConstantName" files="PartitionScanner.java"/>
<suppress checks="ConstantName" files="RsaKey.java"/>
<suppress checks="ConstantName" files="SymmetricKey.java"/>
<suppress checks="ConstantName" files="TaskFailureInformationCodes.java"/>
Expand All @@ -49,12 +43,9 @@
<suppress checks="VisibilityModifier" files="BatchOptions.java"/>
<suppress checks="VisibilityModifier" files="EventHubClientImpl.java"/>

<!-- Public API already released with inner assignment-->
<!-- Unsure if we can modify this existing code without breaking its functionality -->
mssfang marked this conversation as resolved.
Show resolved Hide resolved
<suppress checks="InnerAssignment" files="MessageReceiver.java"/>

<!-- Public API already released with empty block-->
<suppress checks="EmptyBlock" files="MessageReceiver.java"/>
<suppress checks="EmptyBlock" files="InMemoryLeaseManager.java"/>
<!-- Unsure if we can modify this existing code without breaking its functionality -->
<suppress checks="EmptyBlock" files="ReactorDispatcher.java"/>
<suppress checks="EmptyBlock" files="AzureStorageCheckpointLeaseManager.java"/>
</suppressions>