Generate pom file for aggregate code coverage #29035
Conversation
|
/azp run java - core - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - core - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - core - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - resourcemanager - ci |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
/azp run java - resourcemanagerhybrid - ci |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
/azp run java - spring - ci |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
/azp run java - aggregate-reports |
|
Azure Pipelines failed to run 1 pipeline(s). |
srnagar
requested review from
joshfree,
JonathanGiles,
hallipr,
weshaggard and
benbp
as code owners
There was a problem hiding this comment.
@srnagar, I'm happy to see that you'd refactored some of the common elements into the pom_helper.py. Overall I'm good with the changes but there are a couple of minor things
- You're going to want to add the generated pom file to the .gitignore file.
- Shouldn't we be cleaning up the root pom.xml file and the service directory pom.xml files as part of this?
You're going to want to update your sources. My PR changed generate_from_source_pom.py and was merged this morning.
| displayName: 'Generate pom for aggregate code coverage report' | ||
| inputs: | ||
| scriptPath: 'eng/scripts/generate_aggregate_coverage_pom.py' | ||
| arguments: '--groups com.azure' |
There was a problem hiding this comment.
If this is the aggregate report, then shouldn't we be looking at all track 2 groups which would also include com.azure.resourcemanager and com.azure.spring?
There was a problem hiding this comment.
Yes, they will be added to this report as well when the jacoco issues are resolved for mgmt and spring libraries.
There was a problem hiding this comment.
Please add a comment into the yml about this and create bugs to track the jacoco issues for spring and management otherwise it'll never get done.
Done
Once we have a few successful runs with the aggregate pom generation, I'll create a follow-up PR to clean up the root pom.
Done |
| displayName: 'Generate pom for aggregate code coverage report' | ||
| inputs: | ||
| scriptPath: 'eng/scripts/generate_aggregate_coverage_pom.py' | ||
| arguments: '--groups com.azure' |
There was a problem hiding this comment.
Please add a comment into the yml about this and create bugs to track the jacoco issues for spring and management otherwise it'll never get done.
eng/pipelines/aggregate-reports.yml
Outdated
| mavenOptions: '$(MemoryOptions) $(LoggingOptions)' | ||
| javaHomeOption: 'JDKVersion' | ||
| jdkVersionOption: $(JavaBuildVersion) | ||
| jdkArchitectureOption: 'x64' | ||
| publishJUnitResults: false | ||
| goals: 'verify jacoco:report-aggregate' | ||
| goals: 'jacoco:report-aggregate' |
There was a problem hiding this comment.
I'm just curious, why was the verify target removed here?
No description provided.