hostname support wildcard form #26918
Conversation
XiaofeiCao
requested review from
ArthurMa1978,
haolingdong-msft and
weidongxu-microsoft
as code owners
| this.innerModel().withHostname(null); | ||
| // future work: add hostname instead of replacing | ||
| if (hostname == null) { | ||
| this.innerModel().withHostNames(null); |
There was a problem hiding this comment.
Are we allowed to have no hostname in listener?
Ideally if we want to clear a hostname, code should provide a withoutHostname in update flow.
| @@ -20,6 +20,8 @@ | |||
| interface WithHostname<ReturnT> { | |||
| /** | |||
| * Specifies the hostname to reference. | |||
| * The hostname supports wildcard format, e.g. "*.contoso.com", but is available only for | |||
There was a problem hiding this comment.
nit, an extra line break between description and fine detail.
| // override hostnames by hostname | ||
| gateway.innerModel().httpListeners().iterator().next().withHostNames(null).withHostname(hostname1); | ||
| gateway.update() | ||
| .apply(); | ||
|
|
||
| Assertions.assertEquals(hostname1, gateway.listeners().get(listenerName).hostname()); |
There was a problem hiding this comment.
Do we need this test?
There was a problem hiding this comment.
It's for confirmation for service response of replacing hostnames with hostname. I wanted to try the other way around but it's much more complicated..
There was a problem hiding this comment.
You should be able to replace this case with withHostnames if you support it?
|
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
| @@ -248,17 +259,23 @@ public ApplicationGatewayListenerImpl withHttps() { | |||
| @Override | |||
| public ApplicationGatewayListenerImpl withHostname(String hostname) { | |||
| this.innerModel().withHostname(null); | |||
There was a problem hiding this comment.
Move this line into if (hostname != null) {?
| List<String> hostNames = new ArrayList<>(); | ||
| hostNames.add(hostname); | ||
| this.innerModel().withHostNames(hostNames); | ||
| } | ||
| return this; | ||
| } | ||
|
|
||
| @Override | ||
| public ApplicationGatewayListenerImpl withHostnames(List<String> hostnames) { | ||
| this.innerModel().withHostname(null); |
There was a problem hiding this comment.
Move this line into if (hostname != null) {?
...ourcemanager-network/src/main/java/com/azure/resourcemanager/network/models/HasHostname.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Weidong Xu <weidxu@microsoft.com>
…a/com/azure/resourcemanager/network/models/HasHostname.java Co-authored-by: Weidong Xu <weidxu@microsoft.com>
fix #26885