Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove owner role assignments from live test ARM templates #24236

Merged
merged 2 commits into from
Sep 22, 2021

Conversation

benbp
Copy link
Member

@benbp benbp commented Sep 21, 2021

  • Remove owner role assignment from digital twins ARM template

Recent updates to the New-TestResources.ps1 script will do this assignment on deployment already. It is creating role assignment already exists errors for these templates.

FYI @jsquire @heaths @weshaggard @azabbasi

@benbp benbp added the Central-EngSys This issue is owned by the Engineering System team. label Sep 21, 2021
@benbp benbp self-assigned this Sep 21, 2021
@ghost ghost added the Digital Twins label Sep 21, 2021
@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run java - [service] - ci

Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming tests pass.

@benbp
Copy link
Member Author

benbp commented Sep 21, 2021

/azp run java - digitaltwins - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azabbasi
Copy link
Contributor

/azp run java - digitaltwins - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azabbasi azabbasi merged commit 6d049e6 into Azure:main Sep 22, 2021
@benbp benbp deleted the benbp/owner-role-template branch September 22, 2021 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team. Digital Twins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants