Refactor large tests datalake #23267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
/azp run java - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - storage - tests |
1 similar comment
|
/azp run java - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run java - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kasobol-msft
requested review from
alzimmermsft,
amishra-dev and
rickle-msft
as code owners
kasobol-msft
commented
Jul 30, 2021
|
|
||
| @LiveOnly | ||
| @ResourceLock("LargeFileTest") | ||
| @IgnoreIf({ TestEnvironment.getInstance().httpClientType == TestHttpClientType.OK_HTTP || SystemUtils.IS_OS_MAC }) // https://github.com/Azure/azure-sdk-for-java/issues/23221 |
There was a problem hiding this comment.
- mac agents are not co-located with storage account, so disabling there
- okhttp doesn't like payloads larger than int.max... see Support Request Bodies Larger than 2GB in OkHttp HttpClient Implementation #23221
|
/azp run java - storage - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
alzimmermsft
approved these changes
Jul 30, 2021
rickle-msft
approved these changes
Jul 30, 2021
kasobol-msft
commented
Jul 30, 2021
Comment on lines
241
to
243
| <argLine> | ||
| -Xmx6g -Xms6g | ||
| -Xmx6g | ||
| </argLine> |
There was a problem hiding this comment.
Ci didn't like that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remaining part of #12709