Redact PrimaryKey and SecondaryKey of ServiceBus Admin Client test #23246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YijunXieMS
requested review from
alzimmermsft,
anuchandy,
benbp,
conniey,
danieljurek,
g2vinay,
jianghaolu,
JimSuplizio,
ki1729,
lmolkova,
samvaity,
srnagar and
yvgopal
as code owners
ghost
added
alzimmermsft
approved these changes
Jul 29, 2021
Comment on lines
+31
to
+32
| private static final Pattern PRIMARY_KEY_PATTERN = Pattern.compile("(?:<PrimaryKey>)(.*)(?:</PrimaryKey>)"); | ||
| private static final Pattern SECONDARY_KEY_PATTERN = Pattern.compile("(?:<SecondaryKey>)(.*)(?:</SecondaryKey>)"); |
There was a problem hiding this comment.
Another solution for this is to add the redactions when constructing the RecordNetworkCallPolicy in the Service Bus admin client tests with this.
Co-authored-by: Alan Zimmer <48699787+alzimmermsft@users.noreply.github.com>
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-java
that referenced
this pull request
Mar 29, 2023
update newrelic typescript.md (Azure#23246)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.