Fixed the service bus client factory resource release bug. #23195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ZhuXiaoBing-cn
commented
Jul 27, 2021
ZhuXiaoBing-cn
commented
- Fixed the service bus client factory resource release bug.
ZhuXiaoBing-cn
requested review from
backwind1233,
chenrujun,
saragluna,
stliu and
yiliuTo
as code owners
ghost
added
the
backwind1233
approved these changes
Jul 27, 2021
| @@ -41,6 +42,21 @@ public DefaultServiceBusQueueClientFactory(String connectionString, AmqpTranspor | |||
| this.serviceBusClientBuilder.transportType(amqpTransportType); | |||
| } | |||
|
|
|||
| @Override | |||
There was a problem hiding this comment.
FYI: https://docs.spring.io/spring-boot/docs/current/reference/html/features.html#features.spring-application.application-exit
@PreDestroy annotation will work also
|
/azp run java - spring - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.