Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AppConfig] Make sure the consistency behaviors between languages. #22789

Merged
merged 4 commits into from
Jul 6, 2021

Conversation

mssfang
Copy link
Member

@mssfang mssfang commented Jul 6, 2021

For the remaining consistency issue that java has in Azure/azure-sdk#2801.

Changing the strongly-typed properties after setting the value to non-valid feature flag

  1. Create a feature flag
  2. Set the Value to Hello world (no quotes)
  3. Set some strongly typed properties

C#: Value is updated. Strongly typed properties throw on access.
Java: value is updated but don't automatically convert to the strongly-typed property value. no error throws [need to be addressed] // [Resolved] Strongly typed properties throw on access.
Python: Value is updated. Properties throw ValueError on access.
JS: Value is updated. parseFeatureFlag throws since the value can't be parsed

Accessing strongly typed properties after setting a different feature flag JSON

  1. Create a feature flag
  2. Set the Value to some pre-populated
  3. Access strongly-typed property values

C#: Value is updated. Strongly typed properties return new values out of the parsed JSON
Java: value is updated but don't automatically convert to the strongly-typed property value. [need to be addressed]
// [Resolved] Strongly typed properties return new values out of the parsed JSON
Python: Value is updated, properties return new values out of the parsed JSON, returns None if it is not present.
JS: value is updated, parseFeatureFlag does parse the new value

Accessing value after changing strongly-typed properties.

  1. Create a feature flag
  2. Change a strongly-typed property
  3. Does the Value reflect the change?

C#: Yes
Java: Yes
Python: Yes
JS: Yes

@mssfang mssfang added Client This issue points to a problem in the data-plane of the library. App Configuration Azure.ApplicationModel.Configuration labels Jul 6, 2021
@mssfang mssfang added this to the [2021] August milestone Jul 6, 2021
@mssfang mssfang requested a review from pakrym July 6, 2021 18:21
@mssfang mssfang self-assigned this Jul 6, 2021
@mssfang mssfang requested a review from alzimmermsft as a code owner July 6, 2021 18:21
@mssfang mssfang requested review from conniey and srnagar July 6, 2021 18:22
@mssfang mssfang requested a review from srnagar July 6, 2021 20:15
@mssfang mssfang requested a review from srnagar July 6, 2021 22:20
@mssfang mssfang merged commit 9f0aa26 into Azure:main Jul 6, 2021
@mssfang mssfang deleted the AppConfig-consistency branch July 6, 2021 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
App Configuration Azure.ApplicationModel.Configuration Client This issue points to a problem in the data-plane of the library.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants